summaryrefslogtreecommitdiffstats
path: root/gpu
diff options
context:
space:
mode:
authorjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-09 21:49:09 +0000
committerjhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-05-09 21:49:09 +0000
commitd435b07cf3f682a47b9bc0620c234c7ccb589984 (patch)
tree2b1365cbd7a14542c11d0c6541a1475fe7b1a37d /gpu
parent1c514eb439281723557aee8998afd4982762ab3d (diff)
downloadchromium_src-d435b07cf3f682a47b9bc0620c234c7ccb589984.zip
chromium_src-d435b07cf3f682a47b9bc0620c234c7ccb589984.tar.gz
chromium_src-d435b07cf3f682a47b9bc0620c234c7ccb589984.tar.bz2
Coverity: Fix a pass-by-value.
CID=103940 BUG=none TEST=none R=apatrick Review URL: https://chromiumcodereview.appspot.com/10351020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136136 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu')
-rw-r--r--gpu/command_buffer/service/mailbox_manager.cc5
-rw-r--r--gpu/command_buffer/service/mailbox_manager.h6
2 files changed, 6 insertions, 5 deletions
diff --git a/gpu/command_buffer/service/mailbox_manager.cc b/gpu/command_buffer/service/mailbox_manager.cc
index e161fcb..43cb59b 100644
--- a/gpu/command_buffer/service/mailbox_manager.cc
+++ b/gpu/command_buffer/service/mailbox_manager.cc
@@ -107,8 +107,8 @@ MailboxManager::TargetName::TargetName(unsigned target, const MailboxName& name)
name(name) {
}
-bool MailboxManager::TargetNameLess(MailboxManager::TargetName lhs,
- MailboxManager::TargetName rhs) {
+bool MailboxManager::TargetNameLess(const MailboxManager::TargetName& lhs,
+ const MailboxManager::TargetName& rhs) {
return memcmp(&lhs, &rhs, sizeof(lhs)) < 0;
}
@@ -121,5 +121,6 @@ MailboxManager::OwnedTextureDefinition::OwnedTextureDefinition(
MailboxManager::OwnedTextureDefinition::~OwnedTextureDefinition() {
}
+
} // namespace gles2
} // namespace gpu
diff --git a/gpu/command_buffer/service/mailbox_manager.h b/gpu/command_buffer/service/mailbox_manager.h
index e7af1c4..f9ae588 100644
--- a/gpu/command_buffer/service/mailbox_manager.h
+++ b/gpu/command_buffer/service/mailbox_manager.h
@@ -70,7 +70,7 @@ class GPU_EXPORT MailboxManager : public base::RefCounted<MailboxManager> {
MailboxName name;
};
- static bool TargetNameLess(TargetName lhs, TargetName rhs);
+ static bool TargetNameLess(const TargetName& lhs, const TargetName& rhs);
struct OwnedTextureDefinition {
OwnedTextureDefinition(TextureDefinition* definition,
@@ -83,8 +83,8 @@ class GPU_EXPORT MailboxManager : public base::RefCounted<MailboxManager> {
typedef std::map<
TargetName,
OwnedTextureDefinition,
- std::pointer_to_binary_function<TargetName, TargetName, bool> >
- TextureDefinitionMap;
+ std::pointer_to_binary_function<
+ const TargetName&, const TargetName&, bool> > TextureDefinitionMap;
crypto::HMAC hmac_;
TextureDefinitionMap textures_;