diff options
author | jbates@chromium.org <jbates@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-07 20:44:33 +0000 |
---|---|---|
committer | jbates@chromium.org <jbates@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-07 20:44:33 +0000 |
commit | 16adff66ea7224ddd91d01160a7bcc54f5d8b5a6 (patch) | |
tree | 89f6964ede070dc3809db976e6528f0f11d993a1 /gpu | |
parent | f3d5a44568be26375eac9daa7c1a69e36ea6f1bf (diff) | |
download | chromium_src-16adff66ea7224ddd91d01160a7bcc54f5d8b5a6.zip chromium_src-16adff66ea7224ddd91d01160a7bcc54f5d8b5a6.tar.gz chromium_src-16adff66ea7224ddd91d01160a7bcc54f5d8b5a6.tar.bz2 |
We were synchronously destroying the RendererGlContext transfer buffers while commands may still be pending in the command buffer that use them. This generated spurious kOutOfBounds errors. kOutOfBounds errors cause us to kill the associated GpuChannel. That leads to lots of bad behavior, such as failing to reload certain WebGL demos.
This change simply lets the command buffer destroy the shared memory in its destructor instead of destroying them explicitly. The GPU-side resources are cleaned up when the command buffer is destroyed.
BUG=88115
TEST=Open NVIDIA Command Buffer Object WebGL demo; Refresh; Verify successful refresh.
Review URL: http://codereview.chromium.org/7301010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91747 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu')
-rw-r--r-- | gpu/command_buffer/common/constants.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gpu/command_buffer/common/constants.h b/gpu/command_buffer/common/constants.h index 3b06cad..873dfa0 100644 --- a/gpu/command_buffer/common/constants.h +++ b/gpu/command_buffer/common/constants.h @@ -57,7 +57,7 @@ const int32 kCommandBufferSharedMemoryId = 4; const int32 kLatchSharedMemoryId = 5; // Invalid latch ID. -const int32 kInvalidLatchId = 0xffffffffu; +const uint32 kInvalidLatchId = 0xffffffffu; } // namespace gpu |