summaryrefslogtreecommitdiffstats
path: root/gpu
diff options
context:
space:
mode:
authorbenjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-29 17:30:32 +0000
committerbenjhayden@chromium.org <benjhayden@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-06-29 17:30:32 +0000
commit00ae9796073f789661ae8aa506cff92ba19c8f0b (patch)
tree5604064533d41e74bbf2a5a6312919b89fbc1bf5 /gpu
parentea4f850de4781201481cb38a5b7551e0537fb85f (diff)
downloadchromium_src-00ae9796073f789661ae8aa506cff92ba19c8f0b.zip
chromium_src-00ae9796073f789661ae8aa506cff92ba19c8f0b.tar.gz
chromium_src-00ae9796073f789661ae8aa506cff92ba19c8f0b.tar.bz2
Rewrite DownloadsApiTest in C++.
This uses much less magic than the javascript version, so it's more robust and easier to debug and fix. Aaron is the primary reviewer since most of this is extensions-specific. Randy, none of this is particularly downloads-specific. You're welcome to review or mute. ExtensionDownloadsEventRouter sends a chrome::NOTIFICATION_EXTENSION_DOWNLOADS_EVENT notification whenever it fires an event. DownloadsEventsListener is-a content::NotificationObserver that listens for chrome::NOTIFICATION_EXTENSION_DOWNLOADS_EVENT and logs them. DEL facilitates waiting for specific events by running the message loops. BrowserContext::GetFileSystemContext() is used to create HTML5 FileSystem Files. Empty extensions are used because DownloadsDownloadFunction relies on its host permissions mechanisms. I considered grouping all of the new TEST_Fs in a single large TEST_F in order to amortize start-up cost, but that would have required a comment explaining how to disable sub-sections, and it would have complicated time-outs. Besides, most bots can parallelize. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144807 Reverted due to word length mismatch bug in downloads_api_unittest.cc:1581: https://chromiumcodereview.appspot.com/10700024/ Trying again with %d and static_cast<int>(). Review URL: https://chromiumcodereview.appspot.com/10542038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144921 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'gpu')
0 files changed, 0 insertions, 0 deletions