diff options
| author | hidehiko <hidehiko@chromium.org> | 2014-12-10 19:51:21 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-11 03:51:53 +0000 |
| commit | 20a9a3ad484caea1f97b9c8824a79a5c8bf8a958 (patch) | |
| tree | ee76cbf4896ba04a36c559962f6b8d51dc11f86c /ipc/ipc_channel.h | |
| parent | 2ff1341a5b3dc65806b7c6b294240a3f05fe8a81 (diff) | |
| download | chromium_src-20a9a3ad484caea1f97b9c8824a79a5c8bf8a958.zip chromium_src-20a9a3ad484caea1f97b9c8824a79a5c8bf8a958.tar.gz chromium_src-20a9a3ad484caea1f97b9c8824a79a5c8bf8a958.tar.bz2 | |
Non-SFI mode: Use dummy PID for NaCl's IPC channel and IPC channel on Linux platform.
We do not want to expose PID from process on Linux, because it does not play any security role.
Specifically, in NaCl processes, now although getpid() syscall is prohibited by seccomp sandbox, it looks working, probably because of the cache in libc layer.
By this CL, Linux IPC, including nacl_helper_nonsfi, uses dummy PID (-1).
Note; as for nacl_helper process, currently, the process is under PID namespace, so "dummy-like-" PID is already used.
BUG=358465
TEST=Ran trybot.
Review URL: https://codereview.chromium.org/695353005
Cr-Commit-Position: refs/heads/master@{#307853}
Diffstat (limited to 'ipc/ipc_channel.h')
| -rw-r--r-- | ipc/ipc_channel.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/ipc/ipc_channel.h b/ipc/ipc_channel.h index 2fc52cb..8f0f1cb 100644 --- a/ipc/ipc_channel.h +++ b/ipc/ipc_channel.h @@ -211,13 +211,6 @@ class IPC_EXPORT Channel : public Sender { static std::string GenerateVerifiedChannelID(const std::string& prefix); #endif -#if defined(OS_LINUX) - // Sandboxed processes live in a PID namespace, so when sending the IPC hello - // message from client to server we need to send the PID from the global - // PID namespace. - static void SetGlobalPid(int pid); -#endif - #if defined(OS_ANDROID) // Most tests are single process and work the same on all platforms. However // in some cases we want to test multi-process, and Android differs in that it |