diff options
| author | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 12:32:07 +0000 |
|---|---|---|
| committer | thomasvl@chromium.org <thomasvl@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 12:32:07 +0000 |
| commit | 1d88c7f3d3b780274d7d594175271158150ca1e3 (patch) | |
| tree | f353a677d2e210b4f7d51639c72af58012b7be24 /ipc/ipc_channel_posix.cc | |
| parent | dcfb5c0db3c898441e6d1e1f38781a488816a0e4 (diff) | |
| download | chromium_src-1d88c7f3d3b780274d7d594175271158150ca1e3.zip chromium_src-1d88c7f3d3b780274d7d594175271158150ca1e3.tar.gz chromium_src-1d88c7f3d3b780274d7d594175271158150ca1e3.tar.bz2 | |
Revert 51520 - Up the warnings in ipc
add chromium_code:1 to the GYP file
Fix some unittest compares of literal 0 to apis that return size_t
initializer order match declared order
type_id is a uint32, so fix up comparison warnings by using the right type in the test code.
BUG=none
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/2863034
TBR=thomasvl@google.com
Review URL: http://codereview.chromium.org/2852042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51523 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_channel_posix.cc')
| -rw-r--r-- | ipc/ipc_channel_posix.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc index 3f910cf..6e8e2642 100644 --- a/ipc/ipc_channel_posix.cc +++ b/ipc/ipc_channel_posix.cc @@ -699,7 +699,7 @@ bool Channel::ChannelImpl::ProcessIncomingMessages() { // On non-Mac, the Hello message from the client to the server // also contains the fd_pipe_, which will be used for all // subsequent file descriptor passing. - DCHECK_EQ(m.file_descriptor_set()->size(), 1U); + DCHECK_EQ(m.file_descriptor_set()->size(), 1); base::FileDescriptor descriptor; if (!m.ReadFileDescriptor(&iter, &descriptor)) { NOTREACHED(); @@ -777,7 +777,7 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages() { NOTREACHED(); } msg = hello.get(); - DCHECK_EQ(msg->file_descriptor_set()->size(), 1U); + DCHECK_EQ(msg->file_descriptor_set()->size(), 1); } #endif @@ -853,7 +853,7 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages() { if (mode_ != MODE_SERVER && !uses_fifo_ && msg->routing_id() == MSG_ROUTING_NONE && msg->type() == HELLO_MESSAGE_TYPE) { - DCHECK_EQ(msg->file_descriptor_set()->size(), 1U); + DCHECK_EQ(msg->file_descriptor_set()->size(), 1); } if (!uses_fifo_ && !msgh.msg_controllen) { bytes_written = HANDLE_EINTR(write(pipe_, out_bytes, amt_to_write)); |