diff options
author | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 11:47:51 +0000 |
---|---|---|
committer | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 11:47:51 +0000 |
commit | 9eea71c4710393b3bed637382b3f82ec5eb60d2e (patch) | |
tree | 607f3a70a731e7c3e935ecde41986a9d5379ae68 /ipc/ipc_channel_posix.cc | |
parent | 61399a2487f8dcc88f987b2b5d4f2431a29cb8be (diff) | |
download | chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.zip chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.tar.gz chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.tar.bz2 |
Up the warnings in ipc
- add chromium_code:1 to the GYP file
- Fix some unittest compares of literal 0 to apis that return size_t
- initializer order match declared order
- type_id is a uint32, so fix up comparison warnings by using the right type in the test code.
BUG=none
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/2863034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51520 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_channel_posix.cc')
-rw-r--r-- | ipc/ipc_channel_posix.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ipc/ipc_channel_posix.cc b/ipc/ipc_channel_posix.cc index 6e8e2642..3f910cf 100644 --- a/ipc/ipc_channel_posix.cc +++ b/ipc/ipc_channel_posix.cc @@ -699,7 +699,7 @@ bool Channel::ChannelImpl::ProcessIncomingMessages() { // On non-Mac, the Hello message from the client to the server // also contains the fd_pipe_, which will be used for all // subsequent file descriptor passing. - DCHECK_EQ(m.file_descriptor_set()->size(), 1); + DCHECK_EQ(m.file_descriptor_set()->size(), 1U); base::FileDescriptor descriptor; if (!m.ReadFileDescriptor(&iter, &descriptor)) { NOTREACHED(); @@ -777,7 +777,7 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages() { NOTREACHED(); } msg = hello.get(); - DCHECK_EQ(msg->file_descriptor_set()->size(), 1); + DCHECK_EQ(msg->file_descriptor_set()->size(), 1U); } #endif @@ -853,7 +853,7 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages() { if (mode_ != MODE_SERVER && !uses_fifo_ && msg->routing_id() == MSG_ROUTING_NONE && msg->type() == HELLO_MESSAGE_TYPE) { - DCHECK_EQ(msg->file_descriptor_set()->size(), 1); + DCHECK_EQ(msg->file_descriptor_set()->size(), 1U); } if (!uses_fifo_ && !msgh.msg_controllen) { bytes_written = HANDLE_EINTR(write(pipe_, out_bytes, amt_to_write)); |