summaryrefslogtreecommitdiffstats
path: root/ipc/ipc_channel_proxy.h
diff options
context:
space:
mode:
authordcheng <dcheng@chromium.org>2014-10-21 19:29:52 -0700
committerCommit bot <commit-bot@chromium.org>2014-10-22 04:03:51 +0000
commitfe61fca6faca13c54768ee131dc79c8e06421097 (patch)
treed5ec5f4a7321a382c13a6c00461048d33ca2f20d /ipc/ipc_channel_proxy.h
parentffe2c7a61d7f07ee772f7d09d0c04658d350eef1 (diff)
downloadchromium_src-fe61fca6faca13c54768ee131dc79c8e06421097.zip
chromium_src-fe61fca6faca13c54768ee131dc79c8e06421097.tar.gz
chromium_src-fe61fca6faca13c54768ee131dc79c8e06421097.tar.bz2
Standardize usage of virtual/override/final in ipc/
The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. Several formatting edits by clang-format were manually reverted, due to mangling of some of the more complicate IPC macros. BUG=417463 R=agl@chromium.org Review URL: https://codereview.chromium.org/666493005 Cr-Commit-Position: refs/heads/master@{#300623}
Diffstat (limited to 'ipc/ipc_channel_proxy.h')
-rw-r--r--ipc/ipc_channel_proxy.h12
1 files changed, 6 insertions, 6 deletions
diff --git a/ipc/ipc_channel_proxy.h b/ipc/ipc_channel_proxy.h
index 84abc65..71a014b 100644
--- a/ipc/ipc_channel_proxy.h
+++ b/ipc/ipc_channel_proxy.h
@@ -76,7 +76,7 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
Listener* listener,
const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner);
- virtual ~ChannelProxy();
+ ~ChannelProxy() override;
// Initializes the channel proxy. Only call this once to initialize a channel
// proxy that was not initialized in its constructor. If create_pipe_now is
@@ -98,7 +98,7 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
// Send a message asynchronously. The message is routed to the background
// thread where it is passed to the IPC::Channel's Send method.
- virtual bool Send(Message* message) override;
+ bool Send(Message* message) override;
// Used to intercept messages as they are received on the background thread.
//
@@ -152,12 +152,12 @@ class IPC_EXPORT ChannelProxy : public Sender, public base::NonThreadSafe {
protected:
friend class base::RefCountedThreadSafe<Context>;
- virtual ~Context();
+ ~Context() override;
// IPC::Listener methods:
- virtual bool OnMessageReceived(const Message& message) override;
- virtual void OnChannelConnected(int32 peer_pid) override;
- virtual void OnChannelError() override;
+ bool OnMessageReceived(const Message& message) override;
+ void OnChannelConnected(int32 peer_pid) override;
+ void OnChannelError() override;
// Like OnMessageReceived but doesn't try the filters.
bool OnMessageReceivedNoFilter(const Message& message);