diff options
author | dcheng <dcheng@chromium.org> | 2014-10-21 06:52:36 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-21 13:53:03 +0000 |
commit | 39be52ebbd6681c7d79ad63e2a0ab028075af0c2 (patch) | |
tree | 332dfc12477f67daae2f27b933a65ad12e83e2e1 /ipc/ipc_channel_proxy_unittest.cc | |
parent | f85fa223ead04d184ad8a9843042fac4a476c78c (diff) | |
download | chromium_src-39be52ebbd6681c7d79ad63e2a0ab028075af0c2.zip chromium_src-39be52ebbd6681c7d79ad63e2a0ab028075af0c2.tar.gz chromium_src-39be52ebbd6681c7d79ad63e2a0ab028075af0c2.tar.bz2 |
Standardize usage of virtual/override/final in ipc/
This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.
BUG=417463
TBR=agl@chromium.org
Review URL: https://codereview.chromium.org/645623006
Cr-Commit-Position: refs/heads/master@{#300481}
Diffstat (limited to 'ipc/ipc_channel_proxy_unittest.cc')
-rw-r--r-- | ipc/ipc_channel_proxy_unittest.cc | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/ipc/ipc_channel_proxy_unittest.cc b/ipc/ipc_channel_proxy_unittest.cc index 9042f44..848367e 100644 --- a/ipc/ipc_channel_proxy_unittest.cc +++ b/ipc/ipc_channel_proxy_unittest.cc @@ -47,9 +47,9 @@ namespace { class QuitListener : public IPC::Listener { public: QuitListener() : bad_message_received_(false) {} - virtual ~QuitListener() {} + ~QuitListener() override {} - virtual bool OnMessageReceived(const IPC::Message& message) override { + bool OnMessageReceived(const IPC::Message& message) override { IPC_BEGIN_MESSAGE_MAP(QuitListener, message) IPC_MESSAGE_HANDLER(WorkerMsg_Quit, OnQuit) IPC_MESSAGE_HANDLER(TestMsg_BadMessage, OnBadMessage) @@ -57,7 +57,7 @@ class QuitListener : public IPC::Listener { return true; } - virtual void OnBadMessageReceived(const IPC::Message& message) override { + void OnBadMessageReceived(const IPC::Message& message) override { bad_message_received_ = true; } @@ -76,14 +76,14 @@ class QuitListener : public IPC::Listener { class ChannelReflectorListener : public IPC::Listener { public: ChannelReflectorListener() : channel_(NULL) {} - virtual ~ChannelReflectorListener() {} + ~ChannelReflectorListener() override {} void Init(IPC::Channel* channel) { DCHECK(!channel_); channel_ = channel; } - virtual bool OnMessageReceived(const IPC::Message& message) override { + bool OnMessageReceived(const IPC::Message& message) override { IPC_BEGIN_MESSAGE_MAP(ChannelReflectorListener, message) IPC_MESSAGE_HANDLER(TestMsg_Bounce, OnTestBounce) IPC_MESSAGE_HANDLER(TestMsg_SendBadMessage, OnSendBadMessage) @@ -143,24 +143,24 @@ class MessageCountFilter : public IPC::MessageFilter { last_filter_event_(NONE), message_filtering_enabled_(false) {} - virtual void OnFilterAdded(IPC::Sender* sender) override { + void OnFilterAdded(IPC::Sender* sender) override { EXPECT_TRUE(sender); EXPECT_EQ(NONE, last_filter_event_); last_filter_event_ = FILTER_ADDED; } - virtual void OnChannelConnected(int32_t peer_pid) override { + void OnChannelConnected(int32_t peer_pid) override { EXPECT_EQ(FILTER_ADDED, last_filter_event_); EXPECT_NE(static_cast<int32_t>(base::kNullProcessId), peer_pid); last_filter_event_ = CHANNEL_CONNECTED; } - virtual void OnChannelError() override { + void OnChannelError() override { EXPECT_EQ(CHANNEL_CONNECTED, last_filter_event_); last_filter_event_ = CHANNEL_ERROR; } - virtual void OnChannelClosing() override { + void OnChannelClosing() override { // We may or may not have gotten OnChannelError; if not, the last event has // to be OnChannelConnected. if (last_filter_event_ != CHANNEL_ERROR) @@ -168,7 +168,7 @@ class MessageCountFilter : public IPC::MessageFilter { last_filter_event_ = CHANNEL_CLOSING; } - virtual void OnFilterRemoved() override { + void OnFilterRemoved() override { // If the channel didn't get a chance to connect, we might see the // OnFilterRemoved event with no other events preceding it. We still want // OnFilterRemoved to be called to allow for deleting the Filter. @@ -177,7 +177,7 @@ class MessageCountFilter : public IPC::MessageFilter { last_filter_event_ = FILTER_REMOVED; } - virtual bool OnMessageReceived(const IPC::Message& message) override { + bool OnMessageReceived(const IPC::Message& message) override { // We should always get the OnFilterAdded and OnChannelConnected events // prior to any messages. EXPECT_EQ(CHANNEL_CONNECTED, last_filter_event_); @@ -203,7 +203,7 @@ class MessageCountFilter : public IPC::MessageFilter { CHECK(false); } - virtual bool GetSupportedMessageClasses( + bool GetSupportedMessageClasses( std::vector<uint32>* supported_message_classes) const override { if (is_global_filter_) return false; @@ -219,7 +219,7 @@ class MessageCountFilter : public IPC::MessageFilter { FilterEvent last_filter_event() const { return last_filter_event_; } private: - virtual ~MessageCountFilter() {} + ~MessageCountFilter() override {} size_t messages_received_; uint32 supported_message_class_; |