diff options
author | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 11:47:51 +0000 |
---|---|---|
committer | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 11:47:51 +0000 |
commit | 9eea71c4710393b3bed637382b3f82ec5eb60d2e (patch) | |
tree | 607f3a70a731e7c3e935ecde41986a9d5379ae68 /ipc/ipc_fuzzing_tests.cc | |
parent | 61399a2487f8dcc88f987b2b5d4f2431a29cb8be (diff) | |
download | chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.zip chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.tar.gz chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.tar.bz2 |
Up the warnings in ipc
- add chromium_code:1 to the GYP file
- Fix some unittest compares of literal 0 to apis that return size_t
- initializer order match declared order
- type_id is a uint32, so fix up comparison warnings by using the right type in the test code.
BUG=none
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/2863034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51520 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_fuzzing_tests.cc')
-rw-r--r-- | ipc/ipc_fuzzing_tests.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/ipc/ipc_fuzzing_tests.cc b/ipc/ipc_fuzzing_tests.cc index 951ccbb..aaccd70 100644 --- a/ipc/ipc_fuzzing_tests.cc +++ b/ipc/ipc_fuzzing_tests.cc @@ -186,7 +186,7 @@ class FuzzerServerListener : public SimpleListener { Cleanup(); } - bool RoundtripAckReply(int routing, int type_id, int reply) { + bool RoundtripAckReply(int routing, uint32 type_id, int reply) { IPC::Message* message = new IPC::Message(routing, type_id, IPC::Message::PRIORITY_NORMAL); message->WriteInt(reply + 1); @@ -201,7 +201,7 @@ class FuzzerServerListener : public SimpleListener { MessageLoop::current()->Quit(); } - void ReplyMsgNotHandled(int type_id) { + void ReplyMsgNotHandled(uint32 type_id) { RoundtripAckReply(FUZZER_ROUTING_ID, CLIENT_UNHANDLED_IPC, type_id); Cleanup(); } @@ -227,7 +227,7 @@ class FuzzerClientListener : public SimpleListener { MessageLoop::current()->Quit(); } - bool ExpectMessage(int value, int type_id) { + bool ExpectMessage(int value, uint32 type_id) { if (!MsgHandlerInternal(type_id)) return false; int msg_value1 = 0; @@ -247,12 +247,12 @@ class FuzzerClientListener : public SimpleListener { return true; } - bool ExpectMsgNotHandled(int type_id) { + bool ExpectMsgNotHandled(uint32 type_id) { return ExpectMessage(type_id, CLIENT_UNHANDLED_IPC); } private: - bool MsgHandlerInternal(int type_id) { + bool MsgHandlerInternal(uint32 type_id) { MessageLoop::current()->Run(); if (NULL == last_msg_) return false; |