diff options
| author | pinkerton@google.com <pinkerton@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-09 16:06:58 +0000 |
|---|---|---|
| committer | pinkerton@google.com <pinkerton@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-09 16:06:58 +0000 |
| commit | 071b4b94196fafbf3557771d41db81fa9a7d0ba7 (patch) | |
| tree | 6c55110df8cdb9a592e6b79ce3a0bab833dad2bd /ipc/ipc_fuzzing_tests.cc | |
| parent | c9f28a7d16b71b17185b456e3b53e4e638d005d0 (diff) | |
| download | chromium_src-071b4b94196fafbf3557771d41db81fa9a7d0ba7.zip chromium_src-071b4b94196fafbf3557771d41db81fa9a7d0ba7.tar.gz chromium_src-071b4b94196fafbf3557771d41db81fa9a7d0ba7.tar.bz2 | |
Revert 55259 - FBTF: New IPC definitions, only applied to async ROUTED and CONTROL messages.
The slowest cc files in chrome include render_messages.h and other IPC message
definitions. Including one of these files will bring in half of chrome because
in the IPC system previously required full class definitions due to
implementation details.
The new system allows forward declarations and places the implementations of
functions that need the full class definitions (ctor/dtor()/Log() and
superclass ctor/Read() methods) into a separate xxx_messages.cc file using a
parallel set of macros to ipc_message_macros.h. This has the added benefit
of moving most of the template instantiation junk into a small number of
files.
Pros:
- Will speed up compiling by a lot once everything is forward declared.
- Already, intermediary .o/.a files are smaller.
Cons:
- Adds a 4th pass to the messages system, this time in a different header.
BUG=51411
TEST=none
Review URL: http://codereview.chromium.org/2873090
TBR=erg@google.com
Review URL: http://codereview.chromium.org/3080040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55406 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_fuzzing_tests.cc')
| -rw-r--r-- | ipc/ipc_fuzzing_tests.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/ipc/ipc_fuzzing_tests.cc b/ipc/ipc_fuzzing_tests.cc index 9817ade..f9340e6 100644 --- a/ipc/ipc_fuzzing_tests.cc +++ b/ipc/ipc_fuzzing_tests.cc @@ -12,7 +12,6 @@ #include "ipc/ipc_channel.h" #include "ipc/ipc_channel_proxy.h" #include "ipc/ipc_message_utils.h" -#include "ipc/ipc_message_utils_impl.h" #include "ipc/ipc_tests.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/multiprocess_func_list.h" |