Up the warnings in ipc (take 2)

- add chromium_code:1 to the GYP file
- Fix some unittest compares of literal 0 to apis that return size_t
- initializer order match declared order
- type_id is a uint32, so fix up comparison warnings by using the right type in the test code.
- duplicate a type cast used in the ipc headers into the ipc impl to make windows happy.
- msvc warns about getenv, avoid it.

BUG=none
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/2821028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53468 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 11 insertions, 1 deletions

diff --git a/ipc/ipc_logging.cc b/ipc/ipc_logging.cc
index fb2f79b..608abcd 100644
--- a/ipc/ipc_logging.cc
+++ b/ipc/ipc_logging.cc
@@ -49,7 +49,17 @@ Logging::Logging()
       sender_(NULL),
       main_thread_(MessageLoop::current()),
       consumer_(NULL) {
-  if (getenv("CHROME_IPC_LOGGING")) {
+#if defined(OS_WIN)
+  // getenv triggers an unsafe warning. Simply check how big of a buffer
+  // would be needed to fetch the value to see if the enviornment variable is
+  // set.
+  size_t requiredSize = 0;
+  getenv_s(&requiredSize, NULL, 0, "CHROME_IPC_LOGGING");
+  bool logging_env_var_set = (requiredSize != 0);
+#else  // !defined(OS_WIN)
+  bool logging_env_var_set = (getenv("CHROME_IPC_LOGGING") != NULL);
+#endif  //defined(OS_WIN)
+  if (logging_env_var_set) {
     enabled_ = true;
     enabled_on_stderr_ = true;
   }