diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 22:35:26 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-11 22:35:26 +0000 |
commit | 57319cecbf1277567dbd0328fab1ccb741f022ac (patch) | |
tree | 24f52f0c4dd774a09c8a3d7ae5ae781e83e1ec27 /ipc/ipc_message.h | |
parent | 354d49aec9a0bbae84a558bc2cddf4ccb200f955 (diff) | |
download | chromium_src-57319cecbf1277567dbd0328fab1ccb741f022ac.zip chromium_src-57319cecbf1277567dbd0328fab1ccb741f022ac.tar.gz chromium_src-57319cecbf1277567dbd0328fab1ccb741f022ac.tar.bz2 |
Separate out IPC::Message::Sender and Channel::Listener into a separate class.
I fixed the places that did IPC::Channel::Sender (I don't even know how this compiled, but I presume this means the "Sender" base class of the "Channel" which ends up being right).
We can fix the other users of this later.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10541065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141534 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_message.h')
-rw-r--r-- | ipc/ipc_message.h | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/ipc/ipc_message.h b/ipc/ipc_message.h index 2c85e42..c3d4296 100644 --- a/ipc/ipc_message.h +++ b/ipc/ipc_message.h @@ -12,6 +12,9 @@ #include "base/pickle.h" #include "ipc/ipc_export.h" +// TODO(brettw) remove this when the "typedef Sender" is removed below. +#include "ipc/ipc_sender.h" + // Ipc logging adds a dependency from the 'chrome' target on all ipc message // classes. In a component build, this would require exporting all message // classes, so don't support ipc logging in the components build. @@ -39,17 +42,11 @@ struct LogData; class IPC_EXPORT Message : public Pickle { public: - // Implemented by objects that can send IPC messages across a channel. - class IPC_EXPORT Sender { - public: - virtual ~Sender() {} - - // Sends the given IPC message. The implementor takes ownership of the - // given Message regardless of whether or not this method succeeds. This - // is done to make this method easier to use. Returns true on success and - // false otherwise. - virtual bool Send(Message* msg) = 0; - }; + // IPC::Sender used to be IPC::Message::Sender which prevented forward + // declarations. To keep existing code compiling, we provide this backwards- + // compatible definition. New code should use IPC::Sender. + // TODO(brettw) convert users of this and delete. + typedef IPC::Sender Sender; enum PriorityValue { PRIORITY_LOW = 1, |