diff options
author | orenb@chromium.org <orenb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-26 01:29:21 +0000 |
---|---|---|
committer | orenb@chromium.org <orenb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-26 01:29:21 +0000 |
commit | dbc761a8dbaa7e81818b522db0de3797848ff128 (patch) | |
tree | 53dd293439e5a3d89d07e950057caea57b531bda /ipc/ipc_message_utils.cc | |
parent | 2b035305d1d8c06f2d0ac15e7eebd80dba52e9ea (diff) | |
download | chromium_src-dbc761a8dbaa7e81818b522db0de3797848ff128.zip chromium_src-dbc761a8dbaa7e81818b522db0de3797848ff128.tar.gz chromium_src-dbc761a8dbaa7e81818b522db0de3797848ff128.tar.bz2 |
Fixed several CHECKED_RETURN defects in ipc message utils cc
CID_COUNT=3
CID=104154,104155,104156
BUG=
TEST=
TBR=jeremy
Review URL: https://chromiumcodereview.appspot.com/10829024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148469 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_message_utils.cc')
-rw-r--r-- | ipc/ipc_message_utils.cc | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc index 66a6877..29159d0 100644 --- a/ipc/ipc_message_utils.cc +++ b/ipc/ipc_message_utils.cc @@ -51,6 +51,7 @@ bool ReadValue(const Message* m, PickleIterator* iter, Value** value, int recursion); void WriteValue(Message* m, const Value* value, int recursion) { + bool result; if (recursion > kMaxRecursionDepth) { LOG(WARNING) << "Max recursion depth hit in WriteValue."; return; @@ -63,25 +64,29 @@ void WriteValue(Message* m, const Value* value, int recursion) { break; case Value::TYPE_BOOLEAN: { bool val; - value->GetAsBoolean(&val); + result = value->GetAsBoolean(&val); + DCHECK(result); WriteParam(m, val); break; } case Value::TYPE_INTEGER: { int val; - value->GetAsInteger(&val); + result = value->GetAsInteger(&val); + DCHECK(result); WriteParam(m, val); break; } case Value::TYPE_DOUBLE: { double val; - value->GetAsDouble(&val); + result = value->GetAsDouble(&val); + DCHECK(result); WriteParam(m, val); break; } case Value::TYPE_STRING: { std::string val; - value->GetAsString(&val); + result = value->GetAsString(&val); + DCHECK(result); WriteParam(m, val); break; } |