Allow proxy channels to be created without initializing the underlying channel.

This fixes a bug where a client needed to guarantee a message filter was in
place before any messages were received.
It also follows the style of not having constructors that do complex
initialization.
BUG=102894
TEST=none


Review URL: http://codereview.chromium.org/8417054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110229 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 13 insertions, 0 deletions

diff --git a/ipc/ipc_sync_channel.h b/ipc/ipc_sync_channel.h
index e43933e..ae9a765 100644
--- a/ipc/ipc_sync_channel.h
+++ b/ipc/ipc_sync_channel.h
@@ -62,12 +62,22 @@ class SyncMessage;
 class IPC_EXPORT SyncChannel : public ChannelProxy,
                                public base::WaitableEventWatcher::Delegate {
  public:
+  // Creates and initializes a sync channel. If create_pipe_now is specified,
+  // the channel will be initialized synchronously.
   SyncChannel(const IPC::ChannelHandle& channel_handle,
               Channel::Mode mode,
               Channel::Listener* listener,
               base::MessageLoopProxy* ipc_message_loop,
               bool create_pipe_now,
               base::WaitableEvent* shutdown_event);
+
+  // Creates an uninitialized sync channel. Call ChannelProxy::Init to
+  // initialize the channel. This two-step setup allows message filters to be
+  // added before any messages are sent or received.
+  SyncChannel(Channel::Listener* listener,
+              base::MessageLoopProxy* ipc_message_loop,
+              base::WaitableEvent* shutdown_event);
+
   virtual ~SyncChannel();
 
   virtual bool Send(Message* message);
@@ -186,6 +196,9 @@ class IPC_EXPORT SyncChannel : public ChannelProxy,
   // shuts down.
   static void WaitForReplyWithNestedMessageLoop(SyncContext* context);
 
+  // Starts the dispatch watcher.
+  void StartWatching();
+
   bool sync_messages_with_no_timeout_allowed_;
 
   // Used to signal events between the IPC and listener threads.