diff options
| author | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-23 14:18:59 +0000 |
|---|---|---|
| committer | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-23 14:18:59 +0000 |
| commit | 7ee1a44c27384650612290a18ccbe736e0e4b955 (patch) | |
| tree | 563b500ae9e1db27c1659456a33a5f0d7546aaad /ipc/ipc_sync_channel_unittest.cc | |
| parent | 23633b659e6bc5f672197eb90eb6ee50b843ba4a (diff) | |
| download | chromium_src-7ee1a44c27384650612290a18ccbe736e0e4b955.zip chromium_src-7ee1a44c27384650612290a18ccbe736e0e4b955.tar.gz chromium_src-7ee1a44c27384650612290a18ccbe736e0e4b955.tar.bz2 | |
Up the warnings in ipc (take 2)
- add chromium_code:1 to the GYP file
- Fix some unittest compares of literal 0 to apis that return size_t
- initializer order match declared order
- type_id is a uint32, so fix up comparison warnings by using the right type in the test code.
- duplicate a type cast used in the ipc headers into the ipc impl to make windows happy.
- msvc warns about getenv, avoid it.
BUG=none
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/2821028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53468 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/ipc_sync_channel_unittest.cc')
| -rw-r--r-- | ipc/ipc_sync_channel_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ipc/ipc_sync_channel_unittest.cc b/ipc/ipc_sync_channel_unittest.cc index 83b1a7a..87e9773 100644 --- a/ipc/ipc_sync_channel_unittest.cc +++ b/ipc/ipc_sync_channel_unittest.cc @@ -728,8 +728,8 @@ class QueuedReplyClient : public Worker { const std::string& expected_text, bool pump_during_send) : Worker(channel_name, Channel::MODE_CLIENT), - expected_text_(expected_text), - pump_during_send_(pump_during_send) { + pump_during_send_(pump_during_send), + expected_text_(expected_text) { Worker::OverrideThread(listener_thread); } |