diff options
author | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 11:47:51 +0000 |
---|---|---|
committer | thomasvl@google.com <thomasvl@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 11:47:51 +0000 |
commit | 9eea71c4710393b3bed637382b3f82ec5eb60d2e (patch) | |
tree | 607f3a70a731e7c3e935ecde41986a9d5379ae68 /ipc/sync_socket_unittest.cc | |
parent | 61399a2487f8dcc88f987b2b5d4f2431a29cb8be (diff) | |
download | chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.zip chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.tar.gz chromium_src-9eea71c4710393b3bed637382b3f82ec5eb60d2e.tar.bz2 |
Up the warnings in ipc
- add chromium_code:1 to the GYP file
- Fix some unittest compares of literal 0 to apis that return size_t
- initializer order match declared order
- type_id is a uint32, so fix up comparison warnings by using the right type in the test code.
BUG=none
TEST=everything still builds/works
Review URL: http://codereview.chromium.org/2863034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51520 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/sync_socket_unittest.cc')
-rw-r--r-- | ipc/sync_socket_unittest.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ipc/sync_socket_unittest.cc b/ipc/sync_socket_unittest.cc index e07fdf9..a17de68 100644 --- a/ipc/sync_socket_unittest.cc +++ b/ipc/sync_socket_unittest.cc @@ -195,7 +195,7 @@ class SyncSocketClientListener : public IPC::Channel::Listener { socket_->Receive(static_cast<void*>(buf), kHelloStringLength); EXPECT_EQ(strcmp(str.c_str(), buf), 0); // After receiving from the socket there should be no bytes left. - EXPECT_EQ(0, socket_->Peek()); + EXPECT_EQ(0U, socket_->Peek()); IPC::Message* msg = new MsgClassShutdown(); EXPECT_TRUE(chan_->Send(msg)); MessageLoop::current()->Quit(); @@ -220,8 +220,8 @@ TEST_F(SyncSocketTest, SanityTest) { base::SyncSocket* pair[2]; base::SyncSocket::CreatePair(pair); // Immediately after creation there should be no pending bytes. - EXPECT_EQ(0, pair[0]->Peek()); - EXPECT_EQ(0, pair[1]->Peek()); + EXPECT_EQ(0U, pair[0]->Peek()); + EXPECT_EQ(0U, pair[1]->Peek()); base::SyncSocket::Handle target_handle; // Connect the channel and listener. ASSERT_TRUE(chan.Connect()); |