summaryrefslogtreecommitdiffstats
path: root/ipc/sync_socket_unittest.cc
diff options
context:
space:
mode:
authormorrita@chromium.org <morrita@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-30 03:58:59 +0000
committermorrita@chromium.org <morrita@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-30 03:58:59 +0000
commite482111a87c5415af8aaf33636f00c650c19b61e (patch)
tree2aaac1052209eb2ff1d1e3be3dac7f9010bef8b7 /ipc/sync_socket_unittest.cc
parent1df3479c2fff2122dd136c8eb2838034324fae9e (diff)
downloadchromium_src-e482111a87c5415af8aaf33636f00c650c19b61e.zip
chromium_src-e482111a87c5415af8aaf33636f00c650c19b61e.tar.gz
chromium_src-e482111a87c5415af8aaf33636f00c650c19b61e.tar.bz2
Introduce IPC::Channel::Create*() to ensure it being heap-allocated.
This change introduces IPC::Channel::Create*() API to turn IPC::Channel into a heap allocated object. This will allow us to make Channel a polymorphic class. This change also tries to hide Channel::Mode from public API so that we can simplify channel creation code paths cleaner in following changes. ChannelProxy has to follow same pattern to finish this cleanup. Such changes will follow. TEST=none BUG=377980 R=darin@chromium.org,cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273575 Review URL: https://codereview.chromium.org/307653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273713 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc/sync_socket_unittest.cc')
-rw-r--r--ipc/sync_socket_unittest.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/ipc/sync_socket_unittest.cc b/ipc/sync_socket_unittest.cc
index 2888607..5527abc 100644
--- a/ipc/sync_socket_unittest.cc
+++ b/ipc/sync_socket_unittest.cc
@@ -108,11 +108,11 @@ class SyncSocketServerListener : public IPC::Listener {
MULTIPROCESS_IPC_TEST_CLIENT_MAIN(SyncSocketServerClient) {
base::MessageLoopForIO main_message_loop;
SyncSocketServerListener listener;
- IPC::Channel channel(IPCTestBase::GetChannelName("SyncSocketServerClient"),
- IPC::Channel::MODE_CLIENT,
- &listener);
- EXPECT_TRUE(channel.Connect());
- listener.Init(&channel);
+ scoped_ptr<IPC::Channel> channel(IPC::Channel::CreateClient(
+ IPCTestBase::GetChannelName("SyncSocketServerClient"),
+ &listener));
+ EXPECT_TRUE(channel->Connect());
+ listener.Init(channel.get());
base::MessageLoop::current()->Run();
return 0;
}