diff options
author | rbyers@chromium.org <rbyers@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-14 16:19:57 +0000 |
---|---|---|
committer | rbyers@chromium.org <rbyers@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-14 16:19:57 +0000 |
commit | 3b250964a2bc37d956755173fe983a3c17f5951a (patch) | |
tree | 34a7bdaae48bbe278b44c12de5773110b79aa732 /ipc | |
parent | e7ca8dd2ef98a042b7cc7437419067c43cadf1b0 (diff) | |
download | chromium_src-3b250964a2bc37d956755173fe983a3c17f5951a.zip chromium_src-3b250964a2bc37d956755173fe983a3c17f5951a.tar.gz chromium_src-3b250964a2bc37d956755173fe983a3c17f5951a.tar.bz2 |
Revert 121889 - Add simple trace logging of received IPC messages
Somehow triggered a crash in the Windows linker
Adds an entry to chrome://tracing for processing IPC messages that includes the IPC message type ID (which can be matched to a name with the ipclist tool), and in DEBUG builds (or other builds where IPC_MESSAGE_LOG_ENABLED has been set), the message name.
Also adds shell_messages.h to the message generator headers (per the rules in ipc_message_macros.h) to fix broken IPC message logging.
BUG=79942
TEST=
Review URL: http://codereview.chromium.org/9389020
TBR=rbyers@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9365058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121890 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc')
-rw-r--r-- | ipc/ipc_channel_proxy.cc | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc index 0c26267..f542eae 100644 --- a/ipc/ipc_channel_proxy.cc +++ b/ipc/ipc_channel_proxy.cc @@ -1,10 +1,9 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. #include "base/bind.h" #include "base/compiler_specific.h" -#include "base/debug/trace_event.h" #include "base/location.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" @@ -239,23 +238,13 @@ void ChannelProxy::Context::AddFilter(MessageFilter* filter) { // Called on the listener's thread void ChannelProxy::Context::OnDispatchMessage(const Message& message) { -#ifdef IPC_MESSAGE_LOG_ENABLED - Logging* logger = Logging::GetInstance(); - std::string name; - logger->GetMessageText(message.type(), &name, &message, NULL); - TRACE_EVENT1("task", "ChannelProxy::Context::OnDispatchMessage", - "name", name); -#else - TRACE_EVENT1("task", "ChannelProxy::Context::OnDispatchMessage", - "type", message.type()); -#endif - if (!listener_) return; OnDispatchConnected(); #ifdef IPC_MESSAGE_LOG_ENABLED + Logging* logger = Logging::GetInstance(); if (message.type() == IPC_LOGGING_ID) { logger->OnReceivedLoggingMessage(message); return; |