diff options
author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-18 22:33:04 +0000 |
---|---|---|
committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-18 22:33:04 +0000 |
commit | 7d3cbc90c089bb3ba5cb81a5abdc0846d5826def (patch) | |
tree | 8ad0db2d4581c8e935ed1b07c6b4147a5350a204 /ipc | |
parent | bb192b87059a76b89fbc20ad08347c28656e838d (diff) | |
download | chromium_src-7d3cbc90c089bb3ba5cb81a5abdc0846d5826def.zip chromium_src-7d3cbc90c089bb3ba5cb81a5abdc0846d5826def.tar.gz chromium_src-7d3cbc90c089bb3ba5cb81a5abdc0846d5826def.tar.bz2 |
[Cleanup] Remove StringPrintf from global namespace
use of StringPrintf now requires prefixing with base:: or a per-scope using directive
TBR'd:
abodenha: chrome/service
brettw: content, third_party, webkit
darin: base, chrome/browser, chrome/renderer
dgarret: courgette
enne: cc
fischmann: media
gbillock: sql
joi: google_apis,components
rsleevi: net, crypto
sky: chrome/test
thestig: printing, chrome/common,
tsepez: ipc
wez: remoting
yfriedman: testing/android
NOTRY=true
R=brettw@chromium.org
TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12767006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc')
-rw-r--r-- | ipc/ipc_logging.cc | 2 | ||||
-rw-r--r-- | ipc/ipc_message_utils.cc | 19 |
2 files changed, 11 insertions, 10 deletions
diff --git a/ipc/ipc_logging.cc b/ipc/ipc_logging.cc index 21f14c1..0691a9a 100644 --- a/ipc/ipc_logging.cc +++ b/ipc/ipc_logging.cc @@ -241,7 +241,7 @@ void Logging::Log(const LogData& data) { if (enabled_on_stderr_) { std::string message_name; if (data.message_name.empty()) { - message_name = StringPrintf("[unknown type %d]", data.type); + message_name = base::StringPrintf("[unknown type %d]", data.type); } else { message_name = data.message_name; } diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc index 718e759..f3e40fa 100644 --- a/ipc/ipc_message_utils.cc +++ b/ipc/ipc_message_utils.cc @@ -39,11 +39,12 @@ void LogBytes(const std::vector<CharType>& data, std::string* out) { if (isprint(data[i])) out->push_back(data[i]); else - out->append(StringPrintf("[%02X]", static_cast<unsigned char>(data[i]))); + out->append( + base::StringPrintf("[%02X]", static_cast<unsigned char>(data[i]))); } if (data.size() > kMaxBytesToLog) { out->append( - StringPrintf(" and %u more bytes", + base::StringPrintf(" and %u more bytes", static_cast<unsigned>(data.size() - kMaxBytesToLog))); } #endif @@ -309,7 +310,7 @@ bool ParamTraits<float>::Read(const Message* m, PickleIterator* iter, } void ParamTraits<float>::Log(const param_type& p, std::string* l) { - l->append(StringPrintf("%e", p)); + l->append(base::StringPrintf("%e", p)); } void ParamTraits<double>::Write(Message* m, const param_type& p) { @@ -330,7 +331,7 @@ bool ParamTraits<double>::Read(const Message* m, PickleIterator* iter, } void ParamTraits<double>::Log(const param_type& p, std::string* l) { - l->append(StringPrintf("%e", p)); + l->append(base::StringPrintf("%e", p)); } @@ -481,9 +482,9 @@ bool ParamTraits<base::FileDescriptor>::Read(const Message* m, void ParamTraits<base::FileDescriptor>::Log(const param_type& p, std::string* l) { if (p.auto_close) { - l->append(StringPrintf("FD(%d auto-close)", p.fd)); + l->append(base::StringPrintf("FD(%d auto-close)", p.fd)); } else { - l->append(StringPrintf("FD(%d)", p.fd)); + l->append(base::StringPrintf("FD(%d)", p.fd)); } } #endif // defined(OS_POSIX) @@ -668,7 +669,7 @@ bool ParamTraits<IPC::ChannelHandle>::Read(const Message* m, void ParamTraits<IPC::ChannelHandle>::Log(const param_type& p, std::string* l) { - l->append(StringPrintf("ChannelHandle(%s", p.name.c_str())); + l->append(base::StringPrintf("ChannelHandle(%s", p.name.c_str())); #if defined(OS_POSIX) l->append(", "); ParamTraits<base::FileDescriptor>::Log(p.socket, l); @@ -768,7 +769,7 @@ bool ParamTraits<HANDLE>::Read(const Message* m, PickleIterator* iter, } void ParamTraits<HANDLE>::Log(const param_type& p, std::string* l) { - l->append(StringPrintf("0x%X", p)); + l->append(base::StringPrintf("0x%X", p)); } void ParamTraits<LOGFONT>::Write(Message* m, const param_type& p) { @@ -792,7 +793,7 @@ bool ParamTraits<LOGFONT>::Read(const Message* m, PickleIterator* iter, } void ParamTraits<LOGFONT>::Log(const param_type& p, std::string* l) { - l->append(StringPrintf("<LOGFONT>")); + l->append(base::StringPrintf("<LOGFONT>")); } void ParamTraits<MSG>::Write(Message* m, const param_type& p) { |