summaryrefslogtreecommitdiffstats
path: root/ipc
diff options
context:
space:
mode:
authordimich@chromium.org <dimich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-29 05:32:02 +0000
committerdimich@chromium.org <dimich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-29 05:32:02 +0000
commit41225fe51b815b70bdc6df2775fa3f36bd832171 (patch)
tree1dec8870af60ed80282d692a428969e6952dc853 /ipc
parentf7fc18bdc754687e9063edaf6728167e63ca3e95 (diff)
downloadchromium_src-41225fe51b815b70bdc6df2775fa3f36bd832171.zip
chromium_src-41225fe51b815b70bdc6df2775fa3f36bd832171.tar.gz
chromium_src-41225fe51b815b70bdc6df2775fa3f36bd832171.tar.bz2
Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper.
This is the first step of fixing http://crbug.com/196769. The problem is that there are two types of users of Content::DownloadFavicon() - the favicon consumers and regular icons and images consumers. Recently, the otherwise-generic image download+decoding implementation regressed because it was assumed to be only used for favicon loading. The proposed fix is to add a parameter to the method (enum, FAVICON/IMAGE) and rename it from DownloadFavicon to DownloadImage, to make sure the name corresponds to the impl/usage. This is rename-only part, no additional parameter yet. The FaviconHelper class was split in 2, with new ImageLoadingHelper dealing with images. BUG=196769 Review URL: https://chromiumcodereview.appspot.com/12780024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191304 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc')
-rw-r--r--ipc/ipc_message_start.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/ipc/ipc_message_start.h b/ipc/ipc_message_start.h
index b535e92..3a8713f 100644
--- a/ipc/ipc_message_start.h
+++ b/ipc/ipc_message_start.h
@@ -52,7 +52,7 @@ enum IPCMessageStart {
ExtensionMsgStart,
VideoCaptureMsgStart,
QuotaMsgStart,
- IconMsgStart,
+ ImageMsgStart,
TextInputClientMsgStart,
ChromeUtilityMsgStart,
MediaStreamMsgStart,