diff options
| author | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-09 00:59:31 +0000 |
|---|---|---|
| committer | viettrungluu@chromium.org <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-09 00:59:31 +0000 |
| commit | 963a91b1fda682b844b9ece88d2070862f51893f (patch) | |
| tree | 1a12f5e9b33fb4147e130b6ba8203e89b3d8df58 /ipc | |
| parent | a958382be2dbbdd153b01473c4f2498cb9beac28 (diff) | |
| download | chromium_src-963a91b1fda682b844b9ece88d2070862f51893f.zip chromium_src-963a91b1fda682b844b9ece88d2070862f51893f.tar.gz chromium_src-963a91b1fda682b844b9ece88d2070862f51893f.tar.bz2 | |
Get rid of multiprocess_test's debug_on_start arguments.
(It was only ever given a "true" value once, and even that seemed dubious.)
R=phajdan.jr@chromium.org
TBR=darin@chromium.org, jeremy@chromium.org
Review URL: https://codereview.chromium.org/191483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255801 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc')
| -rw-r--r-- | ipc/ipc_channel_posix_unittest.cc | 15 | ||||
| -rw-r--r-- | ipc/ipc_test_base.cc | 7 |
2 files changed, 7 insertions, 15 deletions
diff --git a/ipc/ipc_channel_posix_unittest.cc b/ipc/ipc_channel_posix_unittest.cc index 5157a01..6f3962b 100644 --- a/ipc/ipc_channel_posix_unittest.cc +++ b/ipc/ipc_channel_posix_unittest.cc @@ -285,8 +285,7 @@ TEST_F(IPCChannelPosixTest, AdvancedConnected) { ASSERT_TRUE(channel.AcceptsConnections()); ASSERT_FALSE(channel.HasAcceptedConnection()); - base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc", - false); + base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc"); ASSERT_TRUE(handle); SpinRunLoop(TestTimeouts::action_max_timeout()); ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status()); @@ -315,8 +314,7 @@ TEST_F(IPCChannelPosixTest, ResetState) { ASSERT_TRUE(channel.AcceptsConnections()); ASSERT_FALSE(channel.HasAcceptedConnection()); - base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc", - false); + base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc"); ASSERT_TRUE(handle); SpinRunLoop(TestTimeouts::action_max_timeout()); ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status()); @@ -324,8 +322,7 @@ TEST_F(IPCChannelPosixTest, ResetState) { channel.ResetToAcceptingConnectionState(); ASSERT_FALSE(channel.HasAcceptedConnection()); - base::ProcessHandle handle2 = SpawnChild("IPCChannelPosixTestConnectionProc", - false); + base::ProcessHandle handle2 = SpawnChild("IPCChannelPosixTestConnectionProc"); ASSERT_TRUE(handle2); SpinRunLoop(TestTimeouts::action_max_timeout()); ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status()); @@ -374,14 +371,12 @@ TEST_F(IPCChannelPosixTest, MultiConnection) { ASSERT_TRUE(channel.AcceptsConnections()); ASSERT_FALSE(channel.HasAcceptedConnection()); - base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc", - false); + base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc"); ASSERT_TRUE(handle); SpinRunLoop(TestTimeouts::action_max_timeout()); ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status()); ASSERT_TRUE(channel.HasAcceptedConnection()); - base::ProcessHandle handle2 = SpawnChild("IPCChannelPosixFailConnectionProc", - false); + base::ProcessHandle handle2 = SpawnChild("IPCChannelPosixFailConnectionProc"); ASSERT_TRUE(handle2); SpinRunLoop(TestTimeouts::action_max_timeout()); int exit_code = 0; diff --git a/ipc/ipc_test_base.cc b/ipc/ipc_test_base.cc index b25f844..d3ad4d3 100644 --- a/ipc/ipc_test_base.cc +++ b/ipc/ipc_test_base.cc @@ -12,7 +12,6 @@ #include "base/threading/thread.h" #include "base/time/time.h" #include "ipc/ipc_descriptors.h" -#include "ipc/ipc_switches.h" #if defined(OS_POSIX) #include "base/posix/global_descriptors.h" @@ -96,11 +95,9 @@ bool IPCTestBase::StartClient() { DCHECK(client_process_ == base::kNullProcessHandle); std::string test_main = test_client_name_ + "TestClientMain"; - bool debug_on_start = - CommandLine::ForCurrentProcess()->HasSwitch(switches::kDebugChildren); #if defined(OS_WIN) - client_process_ = SpawnChild(test_main, debug_on_start); + client_process_ = SpawnChild(test_main); #elif defined(OS_POSIX) base::FileHandleMappingVector fds_to_map; const int ipcfd = channel_.get() ? channel_->GetClientFileDescriptor() : @@ -110,7 +107,7 @@ bool IPCTestBase::StartClient() { kPrimaryIPCChannel + base::GlobalDescriptors::kBaseDescriptor)); base::LaunchOptions options; options.fds_to_remap = &fds_to_map; - client_process_ = SpawnChildWithOptions(test_main, options, debug_on_start); + client_process_ = SpawnChildWithOptions(test_main, options); #endif return client_process_ != base::kNullProcessHandle; |