summaryrefslogtreecommitdiffstats
path: root/ipc
diff options
context:
space:
mode:
authorrvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-14 22:10:40 +0000
committerrvargas@google.com <rvargas@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-14 22:10:40 +0000
commit74f87acf261ceb3c804f4b0d71cb38f0f4531270 (patch)
tree5e9cea1d86fc0ed84f79633ce28cbad18816e7ba /ipc
parent56f27b4575b9a7f8c07c78dd3067c18c6d945a81 (diff)
downloadchromium_src-74f87acf261ceb3c804f4b0d71cb38f0f4531270.zip
chromium_src-74f87acf261ceb3c804f4b0d71cb38f0f4531270.tar.gz
chromium_src-74f87acf261ceb3c804f4b0d71cb38f0f4531270.tar.bz2
IPC: remove traces of an old histogram.
BUG=21827 TEST=none Review URL: http://codereview.chromium.org/273060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29038 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc')
-rw-r--r--ipc/ipc_channel_win.cc15
1 files changed, 1 insertions, 14 deletions
diff --git a/ipc/ipc_channel_win.cc b/ipc/ipc_channel_win.cc
index 8aba74f..6a03950 100644
--- a/ipc/ipc_channel_win.cc
+++ b/ipc/ipc_channel_win.cc
@@ -51,11 +51,8 @@ void Channel::ChannelImpl::Close() {
DCHECK(thread_check_->CalledOnValidThread());
}
- bool waited = false;
- if (input_state_.is_pending || output_state_.is_pending) {
+ if (input_state_.is_pending || output_state_.is_pending)
CancelIo(pipe_);
- waited = true;
- }
// Closing the handle at this point prevents us from issuing more requests
// form OnIOCompleted().
@@ -69,16 +66,6 @@ void Channel::ChannelImpl::Close() {
while (input_state_.is_pending || output_state_.is_pending) {
MessageLoopForIO::current()->WaitForIOCompletion(INFINITE, this);
}
- if (waited) {
- // We want to see if we block the message loop for too long.
- // There is a potential race condition here as this function can run from
- // multiple threads, which causes a DCHECK to fire at times from the
- // StatisticsRecorder object indicating that the histogram is being
- // registered multiple times.
- // Commenting out this UMA call for now.
- // Bug http://code.google.com/p/chromium/issues/detail?id=21827
- // UMA_HISTOGRAM_TIMES("AsyncIO.IPCChannelClose", base::Time::Now() - start);
- }
while (!output_queue_.empty()) {
Message* m = output_queue_.front();