diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-28 20:41:10 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-28 20:41:10 +0000 |
| commit | be952c3ca6d93968409b246c9439a7d8c2a06bba (patch) | |
| tree | 501d38ada79c1fddf10f65fe6c88b27a3df4cb1d /ipc | |
| parent | 86c008e8a7da9c00c5a676eb201ba5d0c976748e (diff) | |
| download | chromium_src-be952c3ca6d93968409b246c9439a7d8c2a06bba.zip chromium_src-be952c3ca6d93968409b246c9439a7d8c2a06bba.tar.gz chromium_src-be952c3ca6d93968409b246c9439a7d8c2a06bba.tar.bz2 | |
Fix a ton of compiler warnings.
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc')
| -rw-r--r-- | ipc/ipc_logging.h | 4 | ||||
| -rw-r--r-- | ipc/ipc_sync_channel.h | 10 | ||||
| -rw-r--r-- | ipc/ipc_sync_message.h | 9 |
3 files changed, 13 insertions, 10 deletions
diff --git a/ipc/ipc_logging.h b/ipc/ipc_logging.h index 364ad79..7bbf18c 100644 --- a/ipc/ipc_logging.h +++ b/ipc/ipc_logging.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -30,6 +30,8 @@ class Logging : public base::WaitableEventWatcher::Delegate, class Consumer { public: virtual void Log(const LogData& data) = 0; + protected: + ~Consumer() {} }; void SetConsumer(Consumer* consumer); diff --git a/ipc/ipc_sync_channel.h b/ipc/ipc_sync_channel.h index bfc9eac..741959f 100644 --- a/ipc/ipc_sync_channel.h +++ b/ipc/ipc_sync_channel.h @@ -1,9 +1,9 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef IPC_IPC_SYNC_SENDER_H__ -#define IPC_IPC_SYNC_SENDER_H__ +#ifndef IPC_IPC_SYNC_SENDER_H_ +#define IPC_IPC_SYNC_SENDER_H_ #include <string> #include <deque> @@ -154,9 +154,9 @@ class SyncChannel : public ChannelProxy, base::WaitableEventWatcher send_done_watcher_; base::WaitableEventWatcher dispatch_watcher_; - DISALLOW_EVIL_CONSTRUCTORS(SyncChannel); + DISALLOW_COPY_AND_ASSIGN(SyncChannel); }; } // namespace IPC -#endif // IPC_IPC_SYNC_SENDER_H__ +#endif // IPC_IPC_SYNC_SENDER_H_ diff --git a/ipc/ipc_sync_message.h b/ipc/ipc_sync_message.h index 5d072a7..092fda2 100644 --- a/ipc/ipc_sync_message.h +++ b/ipc/ipc_sync_message.h @@ -1,9 +1,9 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef IPC_IPC_SYNC_MESSAGE_H__ -#define IPC_IPC_SYNC_MESSAGE_H__ +#ifndef IPC_IPC_SYNC_MESSAGE_H_ +#define IPC_IPC_SYNC_MESSAGE_H_ #if defined(OS_WIN) #include <windows.h> @@ -84,6 +84,7 @@ class SyncMessage : public Message { // Used to deserialize parameters from a reply to a synchronous message class MessageReplyDeserializer { public: + virtual ~MessageReplyDeserializer() {} bool SerializeOutputParameters(const Message& msg); private: // Derived classes need to implement this, using the given iterator (which @@ -93,4 +94,4 @@ class MessageReplyDeserializer { } // namespace IPC -#endif // IPC_IPC_SYNC_MESSAGE_H__ +#endif // IPC_IPC_SYNC_MESSAGE_H_ |