diff options
| author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-30 05:24:07 +0000 |
|---|---|---|
| committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-30 05:24:07 +0000 |
| commit | 4038a13d4bc51d5bca8d91443c1cf0952a7fcddf (patch) | |
| tree | 09c039414ccaccaee190038a37707031c37495fd /ipc | |
| parent | b5365e7b8c2ed0184019797039cf4faaaf44dd99 (diff) | |
| download | chromium_src-4038a13d4bc51d5bca8d91443c1cf0952a7fcddf.zip chromium_src-4038a13d4bc51d5bca8d91443c1cf0952a7fcddf.tar.gz chromium_src-4038a13d4bc51d5bca8d91443c1cf0952a7fcddf.tar.bz2 | |
ipc: Do not use Value::Create* functions.
BUG=160586
R=darin@chromium.org,estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12079026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179538 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'ipc')
| -rw-r--r-- | ipc/ipc_message_unittest.cc | 22 | ||||
| -rw-r--r-- | ipc/ipc_message_utils.cc | 8 |
2 files changed, 15 insertions, 15 deletions
diff --git a/ipc/ipc_message_unittest.cc b/ipc/ipc_message_unittest.cc index 4c0d514f..6a40acd 100644 --- a/ipc/ipc_message_unittest.cc +++ b/ipc/ipc_message_unittest.cc @@ -15,9 +15,9 @@ namespace { TEST(IPCMessageTest, ListValue) { ListValue input; - input.Set(0, Value::CreateDoubleValue(42.42)); - input.Set(1, Value::CreateStringValue("forty")); - input.Set(2, Value::CreateNullValue()); + input.Set(0, new base::FundamentalValue(42.42)); + input.Set(1, new base::StringValue("forty")); + input.Set(2, base::Value::CreateNullValue()); IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); IPC::WriteParam(&msg, input); @@ -38,18 +38,18 @@ TEST(IPCMessageTest, ListValue) { TEST(IPCMessageTest, DictionaryValue) { DictionaryValue input; input.Set("null", Value::CreateNullValue()); - input.Set("bool", Value::CreateBooleanValue(true)); - input.Set("int", Value::CreateIntegerValue(42)); - input.SetWithoutPathExpansion("int.with.dot", Value::CreateIntegerValue(43)); + input.Set("bool", new base::FundamentalValue(true)); + input.Set("int", new base::FundamentalValue(42)); + input.SetWithoutPathExpansion("int.with.dot", new base::FundamentalValue(43)); scoped_ptr<DictionaryValue> subdict(new DictionaryValue()); - subdict->Set("str", Value::CreateStringValue("forty two")); - subdict->Set("bool", Value::CreateBooleanValue(false)); + subdict->Set("str", new base::StringValue("forty two")); + subdict->Set("bool", new base::FundamentalValue(false)); scoped_ptr<ListValue> sublist(new ListValue()); - sublist->Set(0, Value::CreateDoubleValue(42.42)); - sublist->Set(1, Value::CreateStringValue("forty")); - sublist->Set(2, Value::CreateStringValue("two")); + sublist->Set(0, new base::FundamentalValue(42.42)); + sublist->Set(1, new base::StringValue("forty")); + sublist->Set(2, new base::StringValue("two")); subdict->Set("list", sublist.release()); input.Set("dict", subdict.release()); diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc index 432853c..a4beb0e 100644 --- a/ipc/ipc_message_utils.cc +++ b/ipc/ipc_message_utils.cc @@ -178,28 +178,28 @@ bool ReadValue(const Message* m, PickleIterator* iter, Value** value, bool val; if (!ReadParam(m, iter, &val)) return false; - *value = Value::CreateBooleanValue(val); + *value = new base::FundamentalValue(val); break; } case Value::TYPE_INTEGER: { int val; if (!ReadParam(m, iter, &val)) return false; - *value = Value::CreateIntegerValue(val); + *value = new base::FundamentalValue(val); break; } case Value::TYPE_DOUBLE: { double val; if (!ReadParam(m, iter, &val)) return false; - *value = Value::CreateDoubleValue(val); + *value = new base::FundamentalValue(val); break; } case Value::TYPE_STRING: { std::string val; if (!ReadParam(m, iter, &val)) return false; - *value = Value::CreateStringValue(val); + *value = new base::StringValue(val); break; } case Value::TYPE_BINARY: { |