summaryrefslogtreecommitdiffstats
path: root/ipc
diff options
context:
space:
mode:
authorjam <jam@chromium.org>2015-11-11 20:39:00 -0800
committerCommit bot <commit-bot@chromium.org>2015-11-12 04:39:50 +0000
commitee99b2d9ec86aa5bbc69169ea26964a6792d286b (patch)
tree99b19e0cb1a75ca2fbe84e360f388ad53a411da9 /ipc
parent37e8a395f1b484d068f81632cb00e029e329699a (diff)
downloadchromium_src-ee99b2d9ec86aa5bbc69169ea26964a6792d286b.zip
chromium_src-ee99b2d9ec86aa5bbc69169ea26964a6792d286b.tar.gz
chromium_src-ee99b2d9ec86aa5bbc69169ea26964a6792d286b.tar.bz2
Fix racy crash in Mandoline child processes.
The problem is with the new EDK, the IO task runner pointer needs to be initialized before MojoMessagePump is created (in child_process.cc). The rest of the change is removing the delegate thread from the InitIPCSupport function. BUG=478251 Review URL: https://codereview.chromium.org/1439863002 Cr-Commit-Position: refs/heads/master@{#359266}
Diffstat (limited to 'ipc')
-rw-r--r--ipc/mojo/scoped_ipc_support.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/ipc/mojo/scoped_ipc_support.cc b/ipc/mojo/scoped_ipc_support.cc
index 2465aa2..58ee518 100644
--- a/ipc/mojo/scoped_ipc_support.cc
+++ b/ipc/mojo/scoped_ipc_support.cc
@@ -104,8 +104,8 @@ void IPCSupportInitializer::Init(
io_thread_task_runner_->PostTask(
FROM_HERE, base::Bind(&WatchMessageLoopOnIOThread, observer_));
mojo::embedder::InitIPCSupport(
- mojo::embedder::ProcessType::NONE, io_thread_task_runner_, this,
- io_thread_task_runner_, mojo::embedder::ScopedPlatformHandle());
+ mojo::embedder::ProcessType::NONE, this, io_thread_task_runner_,
+ mojo::embedder::ScopedPlatformHandle());
}
}