summaryrefslogtreecommitdiffstats
path: root/jingle
diff options
context:
space:
mode:
authordbeam <dbeam@chromium.org>2015-05-04 15:51:18 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-04 22:51:52 +0000
commitdb926e49caab1e225a5ea52764b8b7fefbc982d2 (patch)
tree79cfce5b120a334335724c46342b0280bf6b8ea4 /jingle
parent2b2149aa9dfc5fbbb4ef0df2b89b5f392383f41a (diff)
downloadchromium_src-db926e49caab1e225a5ea52764b8b7fefbc982d2.zip
chromium_src-db926e49caab1e225a5ea52764b8b7fefbc982d2.tar.gz
chromium_src-db926e49caab1e225a5ea52764b8b7fefbc982d2.tar.bz2
Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider so that all provider… (patchset #1 id:1 of https://codereview.chromium.org/1127623003/)
Reason for revert: Still not compiling. Order-dependent revert fun to ensue. End result: this CL and any dependent CL will be re-instated. Original issue's description: > Re-instating r328154 because it's depended on to compile. > > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider so that all provider subclasses can have their state verified. > > Review URL: https://codereview.chromium.org/1114383003 > > Cr-Commit-Position: refs/heads/master@{#328154} > > TBR=rch@chromium.org > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/2b2149aa9dfc5fbbb4ef0df2b89b5f392383f41a TBR=rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1123643006 Cr-Commit-Position: refs/heads/master@{#328206}
Diffstat (limited to 'jingle')
-rw-r--r--jingle/glue/chrome_async_socket_unittest.cc8
1 files changed, 0 insertions, 8 deletions
diff --git a/jingle/glue/chrome_async_socket_unittest.cc b/jingle/glue/chrome_async_socket_unittest.cc
index a785553..78b07a6 100644
--- a/jingle/glue/chrome_async_socket_unittest.cc
+++ b/jingle/glue/chrome_async_socket_unittest.cc
@@ -93,14 +93,6 @@ class AsyncSocketDataProvider : public net::SocketDataProvider {
writes_.push_back(mock_write);
}
- bool AllReadDataConsumed() const override {
- return reads_.empty();
- }
-
- bool AllWriteDataConsumed() const override {
- return writes_.empty();
- }
-
private:
std::deque<net::MockRead> reads_;
bool has_pending_read_;