summaryrefslogtreecommitdiffstats
path: root/jingle
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-01 17:08:20 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-01 17:08:20 +0000
commit601858c0f72ea9693a4796fe6b48558efde46ed7 (patch)
treef9102a4e748ce2f2257f86a748ba6ecfb7087141 /jingle
parenta0709c0dafd07a463a1e9b3553554a0be6cec862 (diff)
downloadchromium_src-601858c0f72ea9693a4796fe6b48558efde46ed7.zip
chromium_src-601858c0f72ea9693a4796fe6b48558efde46ed7.tar.gz
chromium_src-601858c0f72ea9693a4796fe6b48558efde46ed7.tar.bz2
FBTF: Move more ctors/dtors from headers to implementation.
- Adding/Moving dtors of objects that have CancelableRequestConsumers shaves three megs off browser.a. - Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only shaved 100k off browser.a/renderer.a. - Adding/Moving dtors of objects that used some form of base::*Timer<> was negligible; there were only a few classes that had a Timer but had a ctor/dtor in the header after the previous cleanups. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'jingle')
-rw-r--r--jingle/notifier/communicator/ssl_socket_adapter.cc6
-rw-r--r--jingle/notifier/communicator/ssl_socket_adapter.h2
2 files changed, 8 insertions, 0 deletions
diff --git a/jingle/notifier/communicator/ssl_socket_adapter.cc b/jingle/notifier/communicator/ssl_socket_adapter.cc
index 8cc135d..30d28fe 100644
--- a/jingle/notifier/communicator/ssl_socket_adapter.cc
+++ b/jingle/notifier/communicator/ssl_socket_adapter.cc
@@ -72,6 +72,9 @@ SSLSocketAdapter::SSLSocketAdapter(AsyncSocket* socket)
transport_socket_ = new TransportSocket(socket, this);
}
+SSLSocketAdapter::~SSLSocketAdapter() {
+}
+
int SSLSocketAdapter::StartSSL(const char* hostname, bool restartable) {
DCHECK(!restartable);
hostname_ = hostname;
@@ -222,6 +225,9 @@ TransportSocket::TransportSocket(talk_base::AsyncSocket* socket,
socket_->SignalWriteEvent.connect(this, &TransportSocket::OnWriteEvent);
}
+TransportSocket::~TransportSocket() {
+}
+
int TransportSocket::Connect(net::CompletionCallback* callback) {
// Connect is never called by SSLClientSocket, instead SSLSocketAdapter
// calls Connect() on socket_ directly.
diff --git a/jingle/notifier/communicator/ssl_socket_adapter.h b/jingle/notifier/communicator/ssl_socket_adapter.h
index a5f5e9a..42b20a8 100644
--- a/jingle/notifier/communicator/ssl_socket_adapter.h
+++ b/jingle/notifier/communicator/ssl_socket_adapter.h
@@ -29,6 +29,7 @@ class TransportSocket : public net::ClientSocket, public sigslot::has_slots<> {
public:
TransportSocket(talk_base::AsyncSocket* socket,
SSLSocketAdapter *ssl_adapter);
+ ~TransportSocket();
void set_addr(const talk_base::SocketAddress& addr) {
addr_ = addr;
@@ -82,6 +83,7 @@ class TransportSocket : public net::ClientSocket, public sigslot::has_slots<> {
class SSLSocketAdapter : public talk_base::SSLAdapter {
public:
explicit SSLSocketAdapter(talk_base::AsyncSocket* socket);
+ ~SSLSocketAdapter();
// StartSSL returns 0 if successful, or non-zero on failure.
// If StartSSL is called while the socket is closed or connecting, the SSL