summaryrefslogtreecommitdiffstats
path: root/media/audio/audio_io.h
diff options
context:
space:
mode:
authordalecurtis@chromium.org <dalecurtis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-05 06:12:36 +0000
committerdalecurtis@chromium.org <dalecurtis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-05 06:12:36 +0000
commit1b09add967241eb1f56b1f368ee401bf8f79c165 (patch)
tree27d15f5261cc29dd677c9b152f167d31d388292b /media/audio/audio_io.h
parentd385ba9a84e6e0c31604066078048fbd0e6bb89f (diff)
downloadchromium_src-1b09add967241eb1f56b1f368ee401bf8f79c165.zip
chromium_src-1b09add967241eb1f56b1f368ee401bf8f79c165.tar.gz
chromium_src-1b09add967241eb1f56b1f368ee401bf8f79c165.tar.bz2
Privitize WaitTillDataReady() and DataReady().
There's no reason for these to be called all over the code base when we know the limited circumstances under which they must be called. Making these private allows for a considerable cleanup of code. The one sketchy part about this CL is removing PollAndStartIfDataReady() for OSX. I believe stream startup times are long enough that data will always be ready though. If this is not the case and our OSX stats for DataReady() plummet, we can find a simpler solution then polling. This change also fixes inaccuracy with the UMA histogram since previously we were reporting DataReady() after WaitTilDataReady() had already been called. BUG=none TEST=audio plays w/o glitching on mac, win, linux. Review URL: https://chromiumcodereview.appspot.com/16103007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204172 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/audio/audio_io.h')
-rw-r--r--media/audio/audio_io.h4
1 files changed, 0 insertions, 4 deletions
diff --git a/media/audio/audio_io.h b/media/audio/audio_io.h
index 0f3f673..473af0d 100644
--- a/media/audio/audio_io.h
+++ b/media/audio/audio_io.h
@@ -73,10 +73,6 @@ class MEDIA_EXPORT AudioOutputStream {
// playback will not continue.
virtual void OnError(AudioOutputStream* stream) = 0;
- // Will block until the client has written its audio data or 1.5 seconds
- // have elapsed.
- virtual void WaitTillDataReady() {}
-
protected:
virtual ~AudioSourceCallback() {}
};