diff options
| author | xians@chromium.org <xians@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-03 09:13:22 +0000 |
|---|---|---|
| committer | xians@chromium.org <xians@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-03 09:13:22 +0000 |
| commit | 7df6736db0dcefcddd9bc69796d4c302becf1324 (patch) | |
| tree | 3759170ebdc34f5195e5342c474699baafc5392c /media/audio/audio_output_ipc.h | |
| parent | 4d71e95c6059b8ceedaecf5bbfb8b93181edf671 (diff) | |
| download | chromium_src-7df6736db0dcefcddd9bc69796d4c302becf1324.zip chromium_src-7df6736db0dcefcddd9bc69796d4c302becf1324.tar.gz chromium_src-7df6736db0dcefcddd9bc69796d4c302becf1324.tar.bz2 | |
Trying relanding this CL, the original CL passed the try bots but failed the mac 10.7 bot, I am keeping an eye on the bots and will revert it if it fails the bot again.
Hook up the device selection to the WebAudio live audio.
WebAudio live audio needs to pass the session_id to the browser process so that Chrome can open the correct input device for unitfied IO.
This CL looks big because it touches quite some interfaces from the render to the browser. But the change is simple and basically adding a session_id/device_id to the classes. All the changes some together and it is very hard to break it down.
It also makes the media output code more similar to the media input code as well, and it will be easier to merge them for the future.
TBR=henrika@chormium.org
BUG=147327
TEST=http://chromium.googlecode.com/svn/trunk/samples/audio/visualizer-live.html
Change the device using the camera icon on the right of the omnibox, then reload. Verify the sound is coming from the correct input device.
Review URL: https://codereview.chromium.org/15836006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203686 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/audio/audio_output_ipc.h')
| -rw-r--r-- | media/audio/audio_output_ipc.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/media/audio/audio_output_ipc.h b/media/audio/audio_output_ipc.h index 78cf2e7..84f8c6a 100644 --- a/media/audio/audio_output_ipc.h +++ b/media/audio/audio_output_ipc.h @@ -61,10 +61,13 @@ class MEDIA_EXPORT AudioOutputIPC { // Sends a request to create an AudioOutputController object in the peer // process and configures it to use the specified audio |params| including - // number of synchronized input channels. Once the stream has been created, + // number of synchronized input channels.|session_id| is used by the browser + // to select the correct input device if the input channel in |params| is + // valid, otherwise it will be ignored. Once the stream has been created, // the implementation will notify |delegate| by calling OnStreamCreated(). virtual void CreateStream(AudioOutputIPCDelegate* delegate, - const AudioParameters& params) = 0; + const AudioParameters& params, + int session_id) = 0; // Starts playing the stream. This should generate a call to // AudioOutputController::Play(). |