diff options
| author | dalecurtis@google.com <dalecurtis@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-19 04:08:07 +0000 |
|---|---|---|
| committer | dalecurtis@google.com <dalecurtis@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-19 04:08:07 +0000 |
| commit | eaa511edfa1b6a684f431230a59f00604e9ec425 (patch) | |
| tree | ecf1f495550897e13c5b759e2d130d2152f7dc60 /media/audio/audio_output_proxy.cc | |
| parent | 6b236ea282f27cf132d55658b375367e2fd9e18c (diff) | |
| download | chromium_src-eaa511edfa1b6a684f431230a59f00604e9ec425.zip chromium_src-eaa511edfa1b6a684f431230a59f00604e9ec425.tar.gz chromium_src-eaa511edfa1b6a684f431230a59f00604e9ec425.tar.bz2 | |
Promote AudioOutputProxy state machine DCHECKs to CHECKs.
It's possible we're getting into a state where there's an imbalance
between Start() and Stop() calls leaving objects around.
Promote the existing DCHECKs on current state to CHECKs so we
can be sure this is not the case.
BUG=150619
TEST=none
Review URL: https://codereview.chromium.org/10949012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157494 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/audio/audio_output_proxy.cc')
| -rw-r--r-- | media/audio/audio_output_proxy.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/media/audio/audio_output_proxy.cc b/media/audio/audio_output_proxy.cc index a9cfe68..16b7955 100644 --- a/media/audio/audio_output_proxy.cc +++ b/media/audio/audio_output_proxy.cc @@ -19,12 +19,12 @@ AudioOutputProxy::AudioOutputProxy(AudioOutputDispatcher* dispatcher) AudioOutputProxy::~AudioOutputProxy() { DCHECK(CalledOnValidThread()); - DCHECK(state_ == kCreated || state_ == kClosed); + CHECK(state_ == kCreated || state_ == kClosed) << "State is: " << state_; } bool AudioOutputProxy::Open() { DCHECK(CalledOnValidThread()); - DCHECK_EQ(state_, kCreated); + CHECK_EQ(state_, kCreated); if (!dispatcher_->OpenStream()) { state_ = kError; @@ -37,7 +37,7 @@ bool AudioOutputProxy::Open() { void AudioOutputProxy::Start(AudioSourceCallback* callback) { DCHECK(CalledOnValidThread()); - DCHECK_EQ(state_, kOpened); + CHECK_EQ(state_, kOpened); if (!dispatcher_->StartStream(callback, this)) { state_ = kError; |