diff options
| author | xians@chromium.org <xians@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-15 03:59:35 +0000 |
|---|---|---|
| committer | xians@chromium.org <xians@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-15 03:59:35 +0000 |
| commit | 7d5ad4239974cad5843fb605488a8c833716e56c (patch) | |
| tree | 69f4238224ecc2495f5a1fdf7ca027e4aa9c434a /media/audio/linux/alsa_wrapper.h | |
| parent | e1ece30375b913301c3a1c85abe13e3ef51a0f44 (diff) | |
| download | chromium_src-7d5ad4239974cad5843fb605488a8c833716e56c.zip chromium_src-7d5ad4239974cad5843fb605488a8c833716e56c.tar.gz chromium_src-7d5ad4239974cad5843fb605488a8c833716e56c.tar.bz2 | |
There is a complain from Valgrind about invalid memory access in snd_device_name_hint(-1, ..) // -1 means all cards.
It looks like the problem is actually because we use -1 to loop through all the soundcards.
And this patch will loop through the soundcard manually, which should resolve the Valgrind problem.
Bug=96207
Test=media_unittests with Valgrind
Review URL: http://codereview.chromium.org/7888011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101240 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/audio/linux/alsa_wrapper.h')
| -rw-r--r-- | media/audio/linux/alsa_wrapper.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/media/audio/linux/alsa_wrapper.h b/media/audio/linux/alsa_wrapper.h index efe93d0..85cf68a 100644 --- a/media/audio/linux/alsa_wrapper.h +++ b/media/audio/linux/alsa_wrapper.h @@ -19,6 +19,7 @@ class MEDIA_EXPORT AlsaWrapper { virtual int DeviceNameHint(int card, const char* iface, void*** hints); virtual char* DeviceNameGetHint(const void* hint, const char* id); virtual int DeviceNameFreeHint(void** hints); + virtual int CardNext(int* rcard); virtual int PcmOpen(snd_pcm_t** handle, const char* name, snd_pcm_stream_t stream, int mode); |