diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 06:39:06 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-05 06:39:06 +0000 |
commit | f6eeded10a75632e1bc5ecaad9be46553c4ab908 (patch) | |
tree | 8a400e987cd72f1a4b799ce086f3d4169d87b0e9 /media/audio/mac | |
parent | 29a984ff619eb0bdd27bc612bed55f6146cce4fe (diff) | |
download | chromium_src-f6eeded10a75632e1bc5ecaad9be46553c4ab908.zip chromium_src-f6eeded10a75632e1bc5ecaad9be46553c4ab908.tar.gz chromium_src-f6eeded10a75632e1bc5ecaad9be46553c4ab908.tar.bz2 |
Remove size_t from audio IPC code.
The change got to this size because I had to modify the surrounding code (I didn't want to just cast at the last minute).
Review URL: http://codereview.chromium.org/577006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38192 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/audio/mac')
-rw-r--r-- | media/audio/mac/audio_output_mac.cc | 22 | ||||
-rw-r--r-- | media/audio/mac/audio_output_mac.h | 8 | ||||
-rw-r--r-- | media/audio/mac/audio_output_mac_unittest.cc | 16 |
3 files changed, 23 insertions, 23 deletions
diff --git a/media/audio/mac/audio_output_mac.cc b/media/audio/mac/audio_output_mac.cc index 24dc86b..77c34df 100644 --- a/media/audio/mac/audio_output_mac.cc +++ b/media/audio/mac/audio_output_mac.cc @@ -1,13 +1,13 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "media/audio/mac/audio_manager_mac.h" #include "media/audio/mac/audio_output_mac.h" #include "base/basictypes.h" #include "base/logging.h" #include "media/audio/audio_util.h" +#include "media/audio/mac/audio_manager_mac.h" // Overview of operation: // 1) An object of PCMQueueOutAudioOutputStream is created by the AudioManager @@ -78,7 +78,7 @@ void PCMQueueOutAudioOutputStream::HandleError(OSStatus err) { NOTREACHED() << "error code " << err; } -bool PCMQueueOutAudioOutputStream::Open(size_t packet_size) { +bool PCMQueueOutAudioOutputStream::Open(uint32 packet_size) { if (0 == packet_size) { // TODO(cpu) : Impelement default buffer computation. return false; @@ -92,7 +92,7 @@ bool PCMQueueOutAudioOutputStream::Open(size_t packet_size) { return false; } // Allocate the hardware-managed buffers. - for (size_t ix = 0; ix != kNumBuffers; ++ix) { + for (uint32 ix = 0; ix != kNumBuffers; ++ix) { err = AudioQueueAllocateBuffer(audio_queue_, packet_size, &buffer_[ix]); if (err != noErr) { HandleError(err); @@ -113,7 +113,7 @@ void PCMQueueOutAudioOutputStream::Close() { // might be NULL. if (audio_queue_) { OSStatus err = 0; - for (size_t ix = 0; ix != kNumBuffers; ++ix) { + for (uint32 ix = 0; ix != kNumBuffers; ++ix) { if (buffer_[ix]) { err = AudioQueueFreeBuffer(audio_queue_, buffer_[ix]); if (err != noErr) { @@ -168,10 +168,10 @@ void PCMQueueOutAudioOutputStream::GetVolume(double* volume) { // TODO(fbarchard): Switch layout when ffmpeg is updated. namespace { template<class Format> -static void SwizzleLayout(Format* b, size_t filled) { +static void SwizzleLayout(Format* b, uint32 filled) { static const int kNumSurroundChannels = 6; Format aac[kNumSurroundChannels]; - for (size_t i = 0; i < filled; i += sizeof(aac), b += kNumSurroundChannels) { + for (uint32 i = 0; i < filled; i += sizeof(aac), b += kNumSurroundChannels) { memcpy(aac, b, sizeof(aac)); b[0] = aac[1]; // L b[1] = aac[2]; // R @@ -200,8 +200,8 @@ void PCMQueueOutAudioOutputStream::RenderCallback(void* p_this, // Adjust the number of pending bytes by subtracting the amount played. audio_stream->pending_bytes_ -= buffer->mAudioDataByteSize; - size_t capacity = buffer->mAudioDataBytesCapacity; - size_t filled = source->OnMoreData(audio_stream, buffer->mAudioData, + uint32 capacity = buffer->mAudioDataBytesCapacity; + uint32 filled = source->OnMoreData(audio_stream, buffer->mAudioData, capacity, audio_stream->pending_bytes_); // In order to keep the callback running, we need to provide a positive amount @@ -253,12 +253,12 @@ void PCMQueueOutAudioOutputStream::Start(AudioSourceCallback* callback) { source_ = callback; pending_bytes_ = 0; // Ask the source to pre-fill all our buffers before playing. - for (size_t ix = 0; ix != kNumBuffers; ++ix) { + for (uint32 ix = 0; ix != kNumBuffers; ++ix) { buffer_[ix]->mAudioDataByteSize = 0; RenderCallback(this, NULL, buffer_[ix]); } // Queue the buffers to the audio driver, sounds starts now. - for (size_t ix = 0; ix != kNumBuffers; ++ix) { + for (uint32 ix = 0; ix != kNumBuffers; ++ix) { err = AudioQueueEnqueueBuffer(audio_queue_, buffer_[ix], 0, NULL); if (err != noErr) { HandleError(err); diff --git a/media/audio/mac/audio_output_mac.h b/media/audio/mac/audio_output_mac.h index 10fc229..0f58cae 100644 --- a/media/audio/mac/audio_output_mac.h +++ b/media/audio/mac/audio_output_mac.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -29,7 +29,7 @@ class PCMQueueOutAudioOutputStream : public AudioOutputStream { virtual ~PCMQueueOutAudioOutputStream(); // Implementation of AudioOutputStream. - virtual bool Open(size_t packet_size); + virtual bool Open(uint32 packet_size); virtual void Close(); virtual void Start(AudioSourceCallback* callback); virtual void Stop(); @@ -38,7 +38,7 @@ class PCMQueueOutAudioOutputStream : public AudioOutputStream { private: // The audio is double buffered. - static const size_t kNumBuffers = 2; + static const uint32 kNumBuffers = 2; // The OS calls back here when an audio buffer has been processed. static void RenderCallback(void* p_this, AudioQueueRef queue, @@ -61,7 +61,7 @@ class PCMQueueOutAudioOutputStream : public AudioOutputStream { // Volume level from 0 to 1. float volume_; // Number of bytes yet to be played in audio buffer. - int pending_bytes_; + uint32 pending_bytes_; DISALLOW_COPY_AND_ASSIGN(PCMQueueOutAudioOutputStream); }; diff --git a/media/audio/mac/audio_output_mac_unittest.cc b/media/audio/mac/audio_output_mac_unittest.cc index 06d7f96..ee589f5 100644 --- a/media/audio/mac/audio_output_mac_unittest.cc +++ b/media/audio/mac/audio_output_mac_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -19,8 +19,8 @@ using ::testing::Return; class MockAudioSource : public AudioOutputStream::AudioSourceCallback { public: - MOCK_METHOD4(OnMoreData, size_t(AudioOutputStream* stream, void* dest, - size_t max_size, int pending_bytes)); + MOCK_METHOD4(OnMoreData, uint32(AudioOutputStream* stream, void* dest, + uint32 max_size, uint32 pending_bytes)); MOCK_METHOD1(OnClose, void(AudioOutputStream* stream)); MOCK_METHOD2(OnError, void(AudioOutputStream* stream, int code)); }; @@ -28,7 +28,7 @@ class MockAudioSource : public AudioOutputStream::AudioSourceCallback { // Validate that the SineWaveAudioSource writes the expected values for // the FORMAT_16BIT_MONO. TEST(MacAudioTest, SineWaveAudio16MonoTest) { - const size_t samples = 1024; + const uint32 samples = 1024; const int freq = 200; SineWaveAudioSource source(SineWaveAudioSource::FORMAT_16BIT_LINEAR_PCM, 1, @@ -88,7 +88,7 @@ TEST(MacAudioTest, PCMWaveStreamPlay200HzTone44KssMono) { SineWaveAudioSource source(SineWaveAudioSource::FORMAT_16BIT_LINEAR_PCM, 1, 200.0, AudioManager::kAudioCDSampleRate); - size_t bytes_100_ms = (AudioManager::kAudioCDSampleRate / 10) * 2; + uint32 bytes_100_ms = (AudioManager::kAudioCDSampleRate / 10) * 2; EXPECT_TRUE(oas->Open(bytes_100_ms)); @@ -121,7 +121,7 @@ TEST(MacAudioTest, PCMWaveStreamPlay200HzTone22KssMono) { SineWaveAudioSource source(SineWaveAudioSource::FORMAT_16BIT_LINEAR_PCM, 1, 200.0, AudioManager::kAudioCDSampleRate/2); - size_t bytes_100_ms = (AudioManager::kAudioCDSampleRate / 20) * 2; + uint32 bytes_100_ms = (AudioManager::kAudioCDSampleRate / 20) * 2; EXPECT_TRUE(oas->Open(bytes_100_ms)); oas->Start(&source); @@ -132,7 +132,7 @@ TEST(MacAudioTest, PCMWaveStreamPlay200HzTone22KssMono) { // Custom action to clear a memory buffer. static void ClearBuffer(AudioOutputStream* strea, void* dest, - size_t max_size, size_t pending_bytes) { + uint32 max_size, uint32 pending_bytes) { memset(dest, 0, max_size); } @@ -147,7 +147,7 @@ TEST(MacAudioTest, PCMWaveStreamPendingBytes) { ASSERT_TRUE(NULL != oas); NiceMock<MockAudioSource> source; - size_t bytes_100_ms = (AudioManager::kAudioCDSampleRate / 10) * 2; + uint32 bytes_100_ms = (AudioManager::kAudioCDSampleRate / 10) * 2; EXPECT_TRUE(oas->Open(bytes_100_ms)); // We expect the amount of pending bytes will reaching |bytes_100_ms| |