diff options
| author | dalecurtis@chromium.org <dalecurtis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 09:55:49 +0000 |
|---|---|---|
| committer | dalecurtis@chromium.org <dalecurtis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-02 09:55:49 +0000 |
| commit | c1674a529fb13fa97fa108a0dd5d7f93198a5e25 (patch) | |
| tree | ca42a015934f5bcd4d48ff0f40ebbf95d61eae44 /media/base/audio_discard_helper.cc | |
| parent | 7bd79e2ef968908125e7c5baf98e9be422eb39ea (diff) | |
| download | chromium_src-c1674a529fb13fa97fa108a0dd5d7f93198a5e25.zip chromium_src-c1674a529fb13fa97fa108a0dd5d7f93198a5e25.tar.gz chromium_src-c1674a529fb13fa97fa108a0dd5d7f93198a5e25.tar.bz2 | |
Remove AudioBuffer::set_duration(), instead base on frames.
wolenetz@ asked on https://codereview.chromium.org/251893002/ why
we allow set_duration() to be called. It used to be required since
AudioBuffers had no concept of sample rate. However, we now attach
a sample rate to every AudioBuffer which allows us to enforce a
valid duration for every buffer.
This CL also aligns MakeAudioBuffer() to do the same thing with
planar and interleaved data for the sake of easier testing.
BUG=none
TEST=media_unittests
NOTRY=true
Review URL: https://codereview.chromium.org/261533002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267779 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base/audio_discard_helper.cc')
| -rw-r--r-- | media/base/audio_discard_helper.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/media/base/audio_discard_helper.cc b/media/base/audio_discard_helper.cc index 3088130..d868382 100644 --- a/media/base/audio_discard_helper.cc +++ b/media/base/audio_discard_helper.cc @@ -103,10 +103,8 @@ bool AudioDiscardHelper::ProcessBuffers( DCHECK(encoded_buffer->discard_padding() == base::TimeDelta()); } - // Assign timestamp and duration to the buffer. + // Assign timestamp to the buffer. decoded_buffer->set_timestamp(timestamp_helper_.GetTimestamp()); - decoded_buffer->set_duration( - timestamp_helper_.GetFrameDuration(decoded_buffer->frame_count())); timestamp_helper_.AddFrames(decoded_buffer->frame_count()); return true; } |