summaryrefslogtreecommitdiffstats
path: root/media/base/pipeline.h
diff options
context:
space:
mode:
authorscherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-02 17:56:27 +0000
committerscherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-04-02 17:56:27 +0000
commit9bfe9b82466e685d48b0c8fa296e94900155c689 (patch)
treecb348420ed91125842c1eda89e67b8b36b5b7164 /media/base/pipeline.h
parent6d7406e0257912de103c719d8597554edb965271 (diff)
downloadchromium_src-9bfe9b82466e685d48b0c8fa296e94900155c689.zip
chromium_src-9bfe9b82466e685d48b0c8fa296e94900155c689.tar.gz
chromium_src-9bfe9b82466e685d48b0c8fa296e94900155c689.tar.bz2
Remove DemuxerFactory and URL parameter from Pipeline.
Since Demuxers still require asynchronous initialization DemuxerFactory::Build() has been replaced with Demuxer::Initialize(). Since FFmpegDemuxer is the only Demuxer requiring a DataSource it is now passed in via FFmpegDemuxer's constructor. Now that Demuxer::set_host() is guaranteed to be called prior to initialization we're able to tighten up some code inside ChunkDemuxer. We should still nuke set_host() (see bug 111585) but I'll leave that for a future CL. BUG=110804, 110809 Review URL: https://chromiumcodereview.appspot.com/9860027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130165 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base/pipeline.h')
-rw-r--r--media/base/pipeline.h13
1 files changed, 4 insertions, 9 deletions
diff --git a/media/base/pipeline.h b/media/base/pipeline.h
index 9c272ed..f2c7751 100644
--- a/media/base/pipeline.h
+++ b/media/base/pipeline.h
@@ -116,8 +116,8 @@ class MEDIA_EXPORT Pipeline
// Constructs a media pipeline that will execute on |message_loop|.
Pipeline(MessageLoop* message_loop, MediaLog* media_log);
- // Build a pipeline to render the given URL using the given filter collection
- // to construct a filter chain.
+ // Build a pipeline to using the given filter collection to construct a filter
+ // chain.
//
// Pipeline initialization is an inherently asynchronous process. Clients can
// either poll the IsInitialized() method (discouraged) or optionally pass in
@@ -137,7 +137,6 @@ class MEDIA_EXPORT Pipeline
//
// TODO(scherkus): remove IsInitialized() and force clients to use callbacks.
void Start(scoped_ptr<FilterCollection> filter_collection,
- const std::string& url,
const PipelineStatusCB& ended_cb,
const PipelineStatusCB& error_cb,
const NetworkEventCB& network_cb,
@@ -350,7 +349,6 @@ class MEDIA_EXPORT Pipeline
// methods are run as the result of posting a task to the PipelineInternal's
// message loop.
void StartTask(scoped_ptr<FilterCollection> filter_collection,
- const std::string& url,
const PipelineStatusCB& ended_cb,
const PipelineStatusCB& error_cb,
const NetworkEventCB& network_cb,
@@ -404,9 +402,9 @@ class MEDIA_EXPORT Pipeline
// of these methods are only called on the pipeline thread.
// The following initialize methods are used to select a specific type of
- // Filter object from FilterCollection and initialize it asynchronously.
+ // object from FilterCollection and initialize it asynchronously.
void InitializeDemuxer();
- void OnDemuxerBuilt(PipelineStatus status, Demuxer* demuxer);
+ void OnDemuxerInitialized(PipelineStatus status);
// Returns true if the asynchronous action of creating decoder has started.
// Returns false if this method did nothing because the corresponding
@@ -573,9 +571,6 @@ class MEDIA_EXPORT Pipeline
// Filter collection as passed in by Start().
scoped_ptr<FilterCollection> filter_collection_;
- // URL for the data source as passed in by Start().
- std::string url_;
-
// Callbacks for various pipeline operations.
PipelineStatusCB seek_cb_;
base::Closure stop_cb_;