diff options
author | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-15 23:35:31 +0000 |
---|---|---|
committer | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-03-15 23:35:31 +0000 |
commit | a4dae8e1ef4fe6988bb63fcbe7184280f60e98e7 (patch) | |
tree | 8ca0f8a9bf392d37fa49ab114924441f91cfeecf /media/base/pipeline_unittest.cc | |
parent | 89a985ca961f9e4bf90828f5415d3911db62a8a2 (diff) | |
download | chromium_src-a4dae8e1ef4fe6988bb63fcbe7184280f60e98e7.zip chromium_src-a4dae8e1ef4fe6988bb63fcbe7184280f60e98e7.tar.gz chromium_src-a4dae8e1ef4fe6988bb63fcbe7184280f60e98e7.tar.bz2 |
Callback renaming in media code.
This is a follow up CL of 125959.
- Rename AudioTimeCB and VideoTimeCB to TimeCB, as the context (VideoRenderer/AudioRenderer already provides clear context).
- Rename PipelineStatusCB callback variable names to status_cb if no names with specific meaning (e.g. seek_cb) are given.
- Rename foo_callback to foo_cb (except for media/audio/).
Note that media/audio also contains a lot of FooCallback types and foo_callback names. This will probably be addressed in another CL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9704046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127028 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base/pipeline_unittest.cc')
-rw-r--r-- | media/base/pipeline_unittest.cc | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc index 8008f43..83b3c82 100644 --- a/media/base/pipeline_unittest.cc +++ b/media/base/pipeline_unittest.cc @@ -159,8 +159,8 @@ class PipelineTest : public ::testing::Test { } // Sets up expectations to allow the audio renderer to initialize. - void InitializeAudioRenderer(bool disable_after_init_callback = false) { - if (disable_after_init_callback) { + void InitializeAudioRenderer(bool disable_after_init_cb = false) { + if (disable_after_init_cb) { EXPECT_CALL(*mocks_->audio_renderer(), Initialize( scoped_refptr<AudioDecoder>(mocks_->audio_decoder()), _, _, _)) .WillOnce(DoAll(Invoke(&RunPipelineStatusCB4), @@ -854,25 +854,25 @@ TEST_F(PipelineTest, StartTimeIsNonZero) { class FlexibleCallbackRunner : public base::DelegateSimpleThread::Delegate { public: FlexibleCallbackRunner(base::TimeDelta delay, PipelineStatus status, - const PipelineStatusCB& callback) + const PipelineStatusCB& status_cb) : delay_(delay), status_(status), - callback_(callback) { + status_cb_(status_cb) { if (delay_ < base::TimeDelta()) { - callback_.Run(status_); + status_cb_.Run(status_); return; } } virtual void Run() { if (delay_ < base::TimeDelta()) return; base::PlatformThread::Sleep(delay_); - callback_.Run(status_); + status_cb_.Run(status_); } private: base::TimeDelta delay_; PipelineStatus status_; - PipelineStatusCB callback_; + PipelineStatusCB status_cb_; }; void TestPipelineStatusNotification(base::TimeDelta delay) { |