summaryrefslogtreecommitdiffstats
path: root/media/base
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-11-05 21:53:08 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-11-05 21:53:08 +0000
commit877d55dcd3e01d1db858f154a1f369e76b2ebaf2 (patch)
treeee2364ca767826deed3d541603d6c92ca2f0062e /media/base
parentaaa47ee9d83f773d37aa4fd4a04097425ce62063 (diff)
downloadchromium_src-877d55dcd3e01d1db858f154a1f369e76b2ebaf2.zip
chromium_src-877d55dcd3e01d1db858f154a1f369e76b2ebaf2.tar.gz
chromium_src-877d55dcd3e01d1db858f154a1f369e76b2ebaf2.tar.bz2
First patch in making destructors of refcounted objects private.
BUG=26749 Review URL: http://codereview.chromium.org/360042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31136 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base')
-rw-r--r--media/base/buffers.h6
-rw-r--r--media/base/factory.h10
2 files changed, 16 insertions, 0 deletions
diff --git a/media/base/buffers.h b/media/base/buffers.h
index 27ad130..6102ea9 100644
--- a/media/base/buffers.h
+++ b/media/base/buffers.h
@@ -100,6 +100,9 @@ class Buffer : public StreamSample {
// If there's no data in this buffer, it represents end of stream.
virtual bool IsEndOfStream() const { return GetData() == NULL; }
+
+ protected:
+ virtual ~Buffer() {}
};
@@ -114,6 +117,9 @@ class WritableBuffer : public Buffer {
// Returns the size of the underlying buffer.
virtual size_t GetBufferSize() const = 0;
+
+ protected:
+ virtual ~WritableBuffer() {}
};
diff --git a/media/base/factory.h b/media/base/factory.h
index 3ccfcb1..ade8990 100644
--- a/media/base/factory.h
+++ b/media/base/factory.h
@@ -93,6 +93,8 @@ class FilterFactoryCollection : public FilterFactory {
}
private:
+ ~FilterFactoryCollection() {}
+
typedef std::vector< scoped_refptr<FilterFactory> > FactoryVector;
FactoryVector factories_;
@@ -123,6 +125,8 @@ class FilterFactoryImpl0 : public FilterFactory {
}
private:
+ ~FilterFactoryImpl0() {}
+
DISALLOW_COPY_AND_ASSIGN(FilterFactoryImpl0);
};
@@ -152,6 +156,8 @@ class FilterFactoryImpl1 : public FilterFactory {
}
private:
+ ~FilterFactoryImpl1() {}
+
A const a_;
DISALLOW_COPY_AND_ASSIGN(FilterFactoryImpl1);
};
@@ -173,6 +179,8 @@ class FilterFactoryImpl2 : public FilterFactory {
}
private:
+ ~FilterFactoryImpl2() {}
+
A const a_;
B const b_;
@@ -214,6 +222,8 @@ class InstanceFilterFactory : public FilterFactory {
}
private:
+ ~InstanceFilterFactory() {}
+
scoped_refptr<Filter> filter_;
bool create_called_;