diff options
author | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-17 20:20:52 +0000 |
---|---|---|
committer | rsimha@chromium.org <rsimha@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-17 20:20:52 +0000 |
commit | bbca4d6bfe19030a0d5bbb818dc0245453297f72 (patch) | |
tree | edc4baff826d4da8ff527a36ad8866f674e95b10 /media/base | |
parent | a5dad86c566c8c66551a1c0612ae6617613a24e0 (diff) | |
download | chromium_src-bbca4d6bfe19030a0d5bbb818dc0245453297f72.zip chromium_src-bbca4d6bfe19030a0d5bbb818dc0245453297f72.tar.gz chromium_src-bbca4d6bfe19030a0d5bbb818dc0245453297f72.tar.bz2 |
Revert 206775 "[sync] Fix mechanism by which chromeos::UserManag..."
> [sync] Fix mechanism by which chromeos::UserManagerImpl observes ProfileSyncService
>
> When a user signs in to Chrome OS, and NOTIFICATION_PROFILE_ADDED is
> fired, chromeos::UserManagerImpl::Observe() does not register itself as
> an observer of ProfileSyncService because the profile is not yet fully
> constructed, and therefore, the logged in profile is not identified as
> the default profile. This is due to a regression that was introduced in
> r176083.
>
> This is bad because UserManagerImpl fails to observe notifications from
> ProfileSyncService that are sent out as a result of auth errors. In
> fact, this was the root cause of bug http://crbug.com/234164.
>
> This patch fixes the mechanism by which UserManagerImpl registers itself
> as an observer of ProfileSyncService, by responding to
> NOTIFICATION_LOGIN_USER_PROFILE_PREPARED, which is fired after the
> Profile is fully constructed, and the logged in profile is now the
> default profile, resulting in UserManagerImpl correctly registering
> itself as an observer of ProfileSyncService.
>
> This patch also undoes the earlier fix landed with r206203.
>
> This is the true fix for http://crbug.com/234164.
>
> TBR=xiyuan@chromium.org
> BUG=234164, 249918
> TEST=Sign in, change password, sign out and back in; Gaia-reauth must be forced.
>
> Review URL: https://codereview.chromium.org/17022005
TBR=rsimha@chromium.org
Review URL: https://codereview.chromium.org/17291007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206787 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base')
0 files changed, 0 insertions, 0 deletions