diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 23:35:47 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 23:35:47 +0000 |
| commit | 0d7e79fa8ce1bef5ca6d413c908c267c35f5867a (patch) | |
| tree | 5509297bccd2e1b4c8abd0680090547c4b707f18 /media/base | |
| parent | f94151690a90af7029a1ab6ddb0f7679af3a9c7d (diff) | |
| download | chromium_src-0d7e79fa8ce1bef5ca6d413c908c267c35f5867a.zip chromium_src-0d7e79fa8ce1bef5ca6d413c908c267c35f5867a.tar.gz chromium_src-0d7e79fa8ce1bef5ca6d413c908c267c35f5867a.tar.bz2 | |
Revert 61899 for breaking cookes on file:// URLs.
BUG=58553
=================================================
Fix instances of passing raw pointers to RefCounted objects in tasks.
Some of these manually handled it correctly by using AddRef()/Release() pairs. I switched them to make_scoped_refptr() to be more consistent. This also makes them cleanup properly on MessageLoop shutdown if we start deleting tasks.
BUG=28083
TEST=builds
Review URL: http://codereview.chromium.org/3581008
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3654001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62043 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base')
| -rw-r--r-- | media/base/pipeline_impl.cc | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc index 5d7759c..bd9e9fe 100644 --- a/media/base/pipeline_impl.cc +++ b/media/base/pipeline_impl.cc @@ -93,12 +93,8 @@ bool PipelineImpl::Start(FilterFactory* factory, // Kick off initialization! running_ = true; - message_loop_->PostTask( - FROM_HERE, - NewRunnableMethod(this, - &PipelineImpl::StartTask, - make_scoped_refptr(factory), - url, + message_loop_->PostTask(FROM_HERE, + NewRunnableMethod(this, &PipelineImpl::StartTask, factory, url, callback.release())); return true; } |