diff options
author | brettw <brettw@chromium.org> | 2015-08-11 12:30:22 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-08-11 19:31:27 +0000 |
commit | 8e2106dd88a61950569f9cfa8a94ad436d858658 (patch) | |
tree | b95818b8b8d98565bc0beaae50ffb76fa3d82080 /media/base | |
parent | 7d42dad6d95bf258c721f9d15f734bb9d0af8014 (diff) | |
download | chromium_src-8e2106dd88a61950569f9cfa8a94ad436d858658.zip chromium_src-8e2106dd88a61950569f9cfa8a94ad436d858658.tar.gz chromium_src-8e2106dd88a61950569f9cfa8a94ad436d858658.tar.bz2 |
Convert remaining StringToLowerASCII to ToLowerASCII.
Remove StringToLowerASCII. This removes the template and makes a consistent call that can take a string piece.
http_response_headers.cc in HttpResponseHeaders::RemoveHeaderLine there seemed to be a bug where it did
std::string old_header_name_lowercase(name);
where it actually meant
std::string old_header_name_lowercase(old_header_name);
I fixed this.
There were a number of cases where url.host() or url.scheme() was passed to ToLowerASCII. These are already guaranteed lower-case, so I removed the call.
There were a number of cases in net that did return ToLowerASCII().c_str() when the return type is a std::string, which is unnecessary and wasteful. I removed the c_str() call.
NOPRESUBMIT=true
(for touching code with wstrings)
Review URL: https://codereview.chromium.org/1282363003
Cr-Commit-Position: refs/heads/master@{#342869}
Diffstat (limited to 'media/base')
-rw-r--r-- | media/base/mime_util.cc | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/media/base/mime_util.cc b/media/base/mime_util.cc index 50a99c6..2eaf206 100644 --- a/media/base/mime_util.cc +++ b/media/base/mime_util.cc @@ -396,8 +396,7 @@ void MimeUtil::InitializeMimeTypeMaps() { } bool MimeUtil::IsSupportedMediaMimeType(const std::string& mime_type) const { - return media_map_.find(base::StringToLowerASCII(mime_type)) != - media_map_.end(); + return media_map_.find(base::ToLowerASCII(mime_type)) != media_map_.end(); } @@ -439,14 +438,14 @@ void MimeUtil::ParseCodecString(const std::string& codecs, } bool MimeUtil::IsStrictMediaMimeType(const std::string& mime_type) const { - return strict_format_map_.find(base::StringToLowerASCII(mime_type)) != + return strict_format_map_.find(base::ToLowerASCII(mime_type)) != strict_format_map_.end(); } SupportsType MimeUtil::IsSupportedStrictMediaMimeType( const std::string& mime_type, const std::vector<std::string>& codecs) const { - const std::string mime_type_lower_case = base::StringToLowerASCII(mime_type); + const std::string mime_type_lower_case = base::ToLowerASCII(mime_type); StrictMappings::const_iterator it_strict_map = strict_format_map_.find(mime_type_lower_case); if (it_strict_map == strict_format_map_.end()) |