diff options
| author | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-22 06:48:05 +0000 |
|---|---|---|
| committer | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-22 06:48:05 +0000 |
| commit | 6caaacfec964079f6998696334fa62b68facbdba (patch) | |
| tree | e1a65564a82041ce3dbc39203592faed6d86767b /media/base | |
| parent | 03f3551bd3b63c014c7dd02d54293f3c616042c5 (diff) | |
| download | chromium_src-6caaacfec964079f6998696334fa62b68facbdba.zip chromium_src-6caaacfec964079f6998696334fa62b68facbdba.tar.gz chromium_src-6caaacfec964079f6998696334fa62b68facbdba.tar.bz2 | |
Specialize reporting of Media.GpuVideoDecoderInitializeStatus UMA to comply with API requirements.
CreateUMAReportingPipelineCB encouraged abuse of the UMA API in that it accepted
a "name" parameter even though the UMA_HISTOGRAM_* macros must always be called
with the same name from each call-site. Replaced the only call-site with a
specialized version to avoid future bugs.
Review URL: https://codereview.chromium.org/81313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236701 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/base')
| -rw-r--r-- | media/base/pipeline_status.cc | 24 | ||||
| -rw-r--r-- | media/base/pipeline_status.h | 5 |
2 files changed, 0 insertions, 29 deletions
diff --git a/media/base/pipeline_status.cc b/media/base/pipeline_status.cc deleted file mode 100644 index 6c08383..0000000 --- a/media/base/pipeline_status.cc +++ /dev/null @@ -1,24 +0,0 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "media/base/pipeline_status.h" - -#include "base/bind.h" -#include "base/metrics/histogram.h" - -namespace media { - -static void ReportAndRun(const std::string& name, - const PipelineStatusCB& cb, - PipelineStatus status) { - UMA_HISTOGRAM_ENUMERATION(name, status, PIPELINE_STATUS_MAX); - cb.Run(status); -} - -PipelineStatusCB CreateUMAReportingPipelineCB(const std::string& name, - const PipelineStatusCB& cb) { - return base::Bind(&ReportAndRun, name, cb); -} - -} // namespace media diff --git a/media/base/pipeline_status.h b/media/base/pipeline_status.h index c208d01..a9f8585 100644 --- a/media/base/pipeline_status.h +++ b/media/base/pipeline_status.h @@ -37,11 +37,6 @@ enum PipelineStatus { typedef base::Callback<void(PipelineStatus)> PipelineStatusCB; -// Wrap & return a callback around |cb| which reports its argument to UMA under -// the requested |name|. -PipelineStatusCB CreateUMAReportingPipelineCB(const std::string& name, - const PipelineStatusCB& cb); - // TODO(scherkus): this should be moved alongside host interface definitions. struct PipelineStatistics { PipelineStatistics() |