diff options
author | dpranke <dpranke@chromium.org> | 2015-09-29 16:50:41 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-29 23:52:31 +0000 |
commit | 38f4acb69904dca0c39f920fb42c0908d93f4a7d (patch) | |
tree | 57ee162bd2fde146c9390cdddd7afeb752ffc1ad /media/cast/cast_testing.gypi | |
parent | 85a37a27945b310d0ee1a776eedaebc2b217a1a2 (diff) | |
download | chromium_src-38f4acb69904dca0c39f920fb42c0908d93f4a7d.zip chromium_src-38f4acb69904dca0c39f920fb42c0908d93f4a7d.tar.gz chromium_src-38f4acb69904dca0c39f920fb42c0908d93f4a7d.tar.bz2 |
Clean up the environment MB invokes GYP with.
Previously MB would take the environment from the
calling (parent process), update GYP_DEFINES as needed,
and then invoke gyp_chromium. This had the unfortunate effect
that if the parent environment had GYP_CHROMIUM_NO_ACTION
set, gyp_chromium would bail out without doing anything.
This patch re-organizes the logic so that MB will inherit
the parent environment but clear out any GYP-related variables,
and then only set the things it explicitly wants to be set.
Further, the environment will now only be manipulated in one,
so it'll be easier to understand what's going on and keep
things consistent.
R=scottmg@chromium.org
BUG=530733
Review URL: https://codereview.chromium.org/1378003002
Cr-Commit-Position: refs/heads/master@{#351440}
Diffstat (limited to 'media/cast/cast_testing.gypi')
0 files changed, 0 insertions, 0 deletions