diff options
| author | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-28 02:41:47 +0000 |
|---|---|---|
| committer | isherman@chromium.org <isherman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-28 02:41:47 +0000 |
| commit | aac23602db1391f06f0ac6b4eda5abbba4ee1083 (patch) | |
| tree | 668655c492726c6679c4368c3d7073ece1feddf8 /media/media.gyp | |
| parent | 10c6f09565830cbee5b1405d9b2c2689fb6d1c6c (diff) | |
| download | chromium_src-aac23602db1391f06f0ac6b4eda5abbba4ee1083.zip chromium_src-aac23602db1391f06f0ac6b4eda5abbba4ee1083.tar.gz chromium_src-aac23602db1391f06f0ac6b4eda5abbba4ee1083.tar.bz2 | |
Revert 237558 "Use MIDIMessageQueue/IsValidWebMIDIData for MIDI ..."
Seems to have caused issues running perf tests.
BUG=324160
> Use MIDIMessageQueue/IsValidWebMIDIData for MIDI byte stream validation
>
> WebMIDI spec draft: http://www.w3.org/TR/webmidi/
>
> WebMIDI API guarantees that MIDIInput::onmessage is called back with a single MIDI message. To guarantee this, this CL introduces MIDIMessageQueue class, which allows you to
> - maintain fragmented MIDI message.
> - Skip any invalid data sequence.
> - Reorder MIDI messages so that "System Real Time Message", which can be inserted at any point of the byte stream, can be placed at the boundary of complete MIDI messages.
> - (Optional) Reconstruct complete MIDI messages from data stream that is compressed with "running status".
>
> This CL also replaces existing System Exclusive message validation logic in MIDIHost::OnSendData with MIDIHost::IsValidWebMIDIData, which can detect SysEx message even when it is concatenated with non-SysEx messages.
>
> With this change, renderer/blink can be much simpler and free from this kind of data validation.
>
> BUG=303599, 317355
> TEST=media_unittests --gtest_filter=MIDI*, content_unittests --gtest_filter=MIDI*
>
> Review URL: https://codereview.chromium.org/68353002
TBR=yukawa@chromium.org
Review URL: https://codereview.chromium.org/93583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237660 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/media.gyp')
| -rw-r--r-- | media/media.gyp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/media/media.gyp b/media/media.gyp index 5d8fad0..d1e638a 100644 --- a/media/media.gyp +++ b/media/media.gyp @@ -400,10 +400,6 @@ 'midi/midi_manager.h', 'midi/midi_manager_mac.cc', 'midi/midi_manager_mac.h', - 'midi/midi_message_queue.cc', - 'midi/midi_message_queue.h', - 'midi/midi_message_util.cc', - 'midi/midi_message_util.h', 'midi/midi_port_info.cc', 'midi/midi_port_info.h', 'video/capture/android/video_capture_device_android.cc', @@ -984,8 +980,6 @@ 'filters/video_decoder_selector_unittest.cc', 'filters/video_frame_stream_unittest.cc', 'filters/video_renderer_impl_unittest.cc', - 'midi/midi_message_queue_unittest.cc', - 'midi/midi_message_util_unittest.cc', 'video/capture/video_capture_device_unittest.cc', 'webm/cluster_builder.cc', 'webm/cluster_builder.h', |