diff options
| author | dalecurtis <dalecurtis@chromium.org> | 2015-01-21 03:09:24 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-01-21 11:10:51 +0000 |
| commit | 21b128297b19076f5ef83596b9fddbe7c68c4a68 (patch) | |
| tree | 289de476e19fc655603c27994d8347131af80911 /media/mojo/services/mojo_renderer_impl.cc | |
| parent | 6febb4ef7865fada055bcbcae8060df1af343a24 (diff) | |
| download | chromium_src-21b128297b19076f5ef83596b9fddbe7c68c4a68.zip chromium_src-21b128297b19076f5ef83596b9fddbe7c68c4a68.tar.gz chromium_src-21b128297b19076f5ef83596b9fddbe7c68c4a68.tar.bz2 | |
Avoid double task trampoline for Pipeline state transitions.
Previously the initialization of ChunkDemuxer and Seeking would
result in a back to back trampoline of callback tasks, this can
lead to odd interleaving of error states when multiple threads
are involved.
In recent history we've stated it's always the callees job to
ensure callbacks are run on the right thread, this change further
clarifies the contract for Renderers and Demuxers that the callback
given to Initialize() must only be run after Initialize() has
returned.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/827013005
Cr-Commit-Position: refs/heads/master@{#312313}
Diffstat (limited to 'media/mojo/services/mojo_renderer_impl.cc')
| -rw-r--r-- | media/mojo/services/mojo_renderer_impl.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/media/mojo/services/mojo_renderer_impl.cc b/media/mojo/services/mojo_renderer_impl.cc index 8adc9a6..c177031 100644 --- a/media/mojo/services/mojo_renderer_impl.cc +++ b/media/mojo/services/mojo_renderer_impl.cc @@ -55,7 +55,6 @@ void MojoRendererImpl::Initialize( remote_media_renderer_.set_client(this); demuxer_stream_provider_ = demuxer_stream_provider; - // |init_cb| can be called on other thread. init_cb_ = init_cb; ended_cb_ = ended_cb; error_cb_ = error_cb; |