diff options
| author | dalecurtis <dalecurtis@chromium.org> | 2015-05-05 12:58:50 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-05 19:59:16 +0000 |
| commit | 70c8cfac46ea6afbc1858d803f45149c5b227780 (patch) | |
| tree | 91b069d2c63e0be5a04725235d6bf13b03bf191e /media/renderers | |
| parent | 9bd85fa04bbd8bda27f47d88d8389efb6a26d034 (diff) | |
| download | chromium_src-70c8cfac46ea6afbc1858d803f45149c5b227780.zip chromium_src-70c8cfac46ea6afbc1858d803f45149c5b227780.tar.gz chromium_src-70c8cfac46ea6afbc1858d803f45149c5b227780.tar.bz2 | |
Turn new video rendering path on by default, invert flag.
CPU, smoothness, and idle wakeup measures are all drastically improved
and there appear to be no regressions thus far... so flip the flag and
watch the channels for results!
Layout test issues have been fixed by a couple of compositor side CLs
prior to this landing:
http://crrev.com/328220
http://crrev.com/328238
BUG=386551, 396803, 438680, 438766, 439548, 460190
TEST=manual, automated, layout, telemetry.
Review URL: https://codereview.chromium.org/1125673008
Cr-Commit-Position: refs/heads/master@{#328386}
Diffstat (limited to 'media/renderers')
| -rw-r--r-- | media/renderers/video_renderer_impl.cc | 4 | ||||
| -rw-r--r-- | media/renderers/video_renderer_impl.h | 4 | ||||
| -rw-r--r-- | media/renderers/video_renderer_impl_unittest.cc | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/media/renderers/video_renderer_impl.cc b/media/renderers/video_renderer_impl.cc index f493f45..3da6ad4 100644 --- a/media/renderers/video_renderer_impl.cc +++ b/media/renderers/video_renderer_impl.cc @@ -30,8 +30,8 @@ VideoRendererImpl::VideoRendererImpl( const scoped_refptr<MediaLog>& media_log) : task_runner_(task_runner), use_new_video_renderering_path_( - base::CommandLine::ForCurrentProcess()->HasSwitch( - switches::kEnableNewVideoRenderer)), + !base::CommandLine::ForCurrentProcess()->HasSwitch( + switches::kDisableNewVideoRenderer)), sink_(sink), sink_started_(false), video_frame_stream_( diff --git a/media/renderers/video_renderer_impl.h b/media/renderers/video_renderer_impl.h index 43ffd86..8f765f6 100644 --- a/media/renderers/video_renderer_impl.h +++ b/media/renderers/video_renderer_impl.h @@ -82,8 +82,8 @@ class MEDIA_EXPORT VideoRendererImpl bool background_rendering) override; void OnFrameDropped() override; - void enable_new_video_renderer_for_testing() { - use_new_video_renderering_path_ = true; + void disable_new_video_renderer_for_testing() { + use_new_video_renderering_path_ = false; } private: diff --git a/media/renderers/video_renderer_impl_unittest.cc b/media/renderers/video_renderer_impl_unittest.cc index 32a1446..7f5c8d9 100644 --- a/media/renderers/video_renderer_impl_unittest.cc +++ b/media/renderers/video_renderer_impl_unittest.cc @@ -64,8 +64,8 @@ class VideoRendererImplTest : public testing::TestWithParam<bool> { renderer_.reset(new VideoRendererImpl( message_loop_.message_loop_proxy(), null_video_sink_.get(), decoders.Pass(), true, new MediaLog())); - if (GetParam()) - renderer_->enable_new_video_renderer_for_testing(); + if (!GetParam()) + renderer_->disable_new_video_renderer_for_testing(); renderer_->SetTickClockForTesting(scoped_ptr<base::TickClock>(tick_clock_)); null_video_sink_->set_tick_clock_for_testing(tick_clock_); |