diff options
| author | imasaki@google.com <imasaki@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-09 17:25:31 +0000 |
|---|---|---|
| committer | imasaki@google.com <imasaki@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-09 17:25:31 +0000 |
| commit | 9f3565c0dace4580befd48308c4cc4bdfaa36a3e (patch) | |
| tree | d83a7b3454b9af76d25a1e23e2df3f3d9ce51fb0 /media/tools | |
| parent | bc552e6f525d9b46096ccb2c03d856d165d8f15a (diff) | |
| download | chromium_src-9f3565c0dace4580befd48308c4cc4bdfaa36a3e.zip chromium_src-9f3565c0dace4580befd48308c4cc4bdfaa36a3e.tar.gz chromium_src-9f3565c0dace4580befd48308c4cc4bdfaa36a3e.tar.bz2 | |
Modification based on CR comments.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100424 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/tools')
| -rw-r--r-- | media/tools/layout_tests/layouttest_analyzer.py | 4 | ||||
| -rw-r--r-- | media/tools/layout_tests/layouttest_analyzer_helpers.py | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/media/tools/layout_tests/layouttest_analyzer.py b/media/tools/layout_tests/layouttest_analyzer.py index 6f48e54..e5f5251 100644 --- a/media/tools/layout_tests/layouttest_analyzer.py +++ b/media/tools/layout_tests/layouttest_analyzer.py @@ -144,8 +144,8 @@ def main(): prev_analyzer_result_map) result_change = (any(diff_map['whole']) or any(diff_map['skip']) or any(diff_map['nonskip'])) - # Do not email when |email_only_change_mode| is true and there is no change - # in the result compared to the last result. + # Email only when |email_only_change_mode| is False or there + # is a change in the result compared to the last result. if not options.email_only_change_mode or result_change: layouttest_analyzer_helpers.SendStatusEmail( prev_time, analyzer_result_map, diff_map, anno_map, diff --git a/media/tools/layout_tests/layouttest_analyzer_helpers.py b/media/tools/layout_tests/layouttest_analyzer_helpers.py index 6b147e9..e0c215f 100644 --- a/media/tools/layout_tests/layouttest_analyzer_helpers.py +++ b/media/tools/layout_tests/layouttest_analyzer_helpers.py @@ -195,9 +195,9 @@ class AnalyzerResultMap: simplicity), comp_result_map['whole'][0] = ['foo1.html'] comp_result_map['whole'][1] = ['foo2.html'] - This means that current result has 'foo1.html' but NOT in the + This means that current result has 'foo1.html' but it is NOT in the previous result. This also means the previous result has 'foo2.html' - but it is NOT the current result. + but it is NOT in the current result. """ comp_result_map = {} for name in ['whole', 'skip', 'nonskip']: @@ -281,9 +281,9 @@ def SendStatusEmail(prev_time, analyzer_result_map, diff_map, simplicity), comp_result_map['whole'][0] = ['foo1.html'] comp_result_map['whole'][1] = ['foo2.html'] - This means that current result has 'foo1.html' but NOT in the + This means that current result has 'foo1.html' but it is NOT in the previous result. This also means the previous result has 'foo2.html' - but it is NOT the current result. + but it is NOT in the current result. bug_anno_map: bug annotation map where bug name and annotations are stored. receiver_email_address: receiver's email address. |