diff options
author | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 18:17:30 +0000 |
---|---|---|
committer | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-13 18:17:30 +0000 |
commit | 436fd41df6378a81cbd8706eb9b1daed95cc7cab (patch) | |
tree | d40cbe4296f2b39dc9221e48a90ff7d53140003e /media/video/picture.h | |
parent | 67351452e1e16cb9b01c609ce185a9e819cf2254 (diff) | |
download | chromium_src-436fd41df6378a81cbd8706eb9b1daed95cc7cab.zip chromium_src-436fd41df6378a81cbd8706eb9b1daed95cc7cab.tar.gz chromium_src-436fd41df6378a81cbd8706eb9b1daed95cc7cab.tar.bz2 |
Overhauled OmxVideoDecodeAccelerator's state machine implementation and related code.
This implementation makes explicit the transitions being effected and the states
expected to be involved in each transition, instead of the previous
implementation's use of implicit information (e.g. "we just went from Idle to
Loaded, therefore we must be Abort()'ing"). This is not only much more readable
but also enables implementation of Reset() (for Seek) and replaces Abort()
(which never had a well-defined purpose that was consistent in documentation and
implementation, nor a customer use-case).
DID some TODOs in OmxVideoDecodeAccelerator:
- Replaced error-code checking boilerplate w/ a failure-handling macro.
- Simplified the component-name-getting dance in CreateComponent().
Updated the PPAPI interface:
- Removed GetConfigs & AssignSysmemBuffers (neither of which ever came into its own)
- Replaced Abort with Reset, and added Destroy (which still nobody calls, but
that'll change shortly).
- Cleaned up the interface's documentation.
BUG=86122
TEST=OVDATest, gles2 sample plugin
Review URL: http://codereview.chromium.org/7338010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92383 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media/video/picture.h')
-rw-r--r-- | media/video/picture.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/media/video/picture.h b/media/video/picture.h index e0ac773..0126002 100644 --- a/media/video/picture.h +++ b/media/video/picture.h @@ -50,6 +50,10 @@ class GLESBuffer : public BaseBuffer { uint32 texture_id_; }; +// TODO(fischman,vrk): rip out SysmemBuffer and all its vestiges (such as +// BaseBuffer's existence, VideoDecodeAccelerator::MemoryType, their ppapi +// equivalents, etc). Rename GLESBuffer to PictureBuffer. + // A picture buffer that lives in system memory. // This is the media-namespace equivalent of PP_SysmemBuffer_Dev. class SysmemBuffer : public BaseBuffer { |