summaryrefslogtreecommitdiffstats
path: root/media
diff options
context:
space:
mode:
authorhclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-29 06:32:36 +0000
committerhclam@chromium.org <hclam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-29 06:32:36 +0000
commit8938fd7cbb8b8dea620c67fdf9355842e802097b (patch)
tree656cb169bc2f6e1e06b6fb2e0defdcda1cd48fe5 /media
parent55c40eb52838e5b4b8b12c2eaca722c0c2c4d27c (diff)
downloadchromium_src-8938fd7cbb8b8dea620c67fdf9355842e802097b.zip
chromium_src-8938fd7cbb8b8dea620c67fdf9355842e802097b.tar.gz
chromium_src-8938fd7cbb8b8dea620c67fdf9355842e802097b.tar.bz2
Some cleanup work in GpuVideoDecoderHost and IpcVideoDecoder
Seeing that GpuVideoDecoderHost has a very similar interface to VideoDecodeEngine, this patch makes GpuVideoDecoderHost implments VideoDecodeEngine. Also did some cleanup work to remove code patch that doesn't fit into the buffer allocation model we are moving to. BUG=53714 TEST=Tree is green. Code still doesn't work yet. Review URL: http://codereview.chromium.org/3393014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60912 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media')
-rw-r--r--media/video/video_decode_context.h4
-rw-r--r--media/video/video_decode_engine.h1
2 files changed, 3 insertions, 2 deletions
diff --git a/media/video/video_decode_context.h b/media/video/video_decode_context.h
index f1e678d..7bd6741 100644
--- a/media/video/video_decode_context.h
+++ b/media/video/video_decode_context.h
@@ -72,10 +72,10 @@ class VideoDecodeContext {
Task* task) = 0;
// Destroy this context asynchronously. When the operation is done |task|
- // is called.
+ // is called. It is safe to delete this object only after |task| is called.
//
// ReleaseVideoFrames() need to be called with all the video frames allocated
- // before making this call.
+ // before making this call.
virtual void Destroy(Task* task) = 0;
};
diff --git a/media/video/video_decode_engine.h b/media/video/video_decode_engine.h
index f9381a2..0cd96b3 100644
--- a/media/video/video_decode_engine.h
+++ b/media/video/video_decode_engine.h
@@ -66,6 +66,7 @@ struct VideoCodecInfo {
bool success;
// Whether decoder provides output buffer pool.
+ // TODO(hclam): This is not important anymore. Remove this.
bool provides_buffers;
// Initial Stream Info. Only part of them could be valid.