diff options
| author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 02:01:17 +0000 |
|---|---|---|
| committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 02:01:17 +0000 |
| commit | bd954489c842f1399e249fa0fb2757da5a6eecf2 (patch) | |
| tree | 0d571d16067a3c7659b729ee81e8878cb56f47a9 /media | |
| parent | e5de055f92de1859eb313c7c4e1e8e35323c8d10 (diff) | |
| download | chromium_src-bd954489c842f1399e249fa0fb2757da5a6eecf2.zip chromium_src-bd954489c842f1399e249fa0fb2757da5a6eecf2.tar.gz chromium_src-bd954489c842f1399e249fa0fb2757da5a6eecf2.tar.bz2 | |
Updated some comments to point at bugs in ffmpeg_unittest.cc and ffmpeg_audio_decoder.cc.
No code change.
BUG=49709,50457
TEST=none
TBR=hclam
Review URL: http://codereview.chromium.org/3077004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53896 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media')
| -rw-r--r-- | media/ffmpeg/ffmpeg_unittest.cc | 18 | ||||
| -rw-r--r-- | media/filters/ffmpeg_audio_decoder.cc | 2 |
2 files changed, 19 insertions, 1 deletions
diff --git a/media/ffmpeg/ffmpeg_unittest.cc b/media/ffmpeg/ffmpeg_unittest.cc index 233c66c..0892d9d 100644 --- a/media/ffmpeg/ffmpeg_unittest.cc +++ b/media/ffmpeg/ffmpeg_unittest.cc @@ -2,6 +2,24 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ffmpeg_unittests verify that the parts of the FFmpeg API that Chromium uses +// function as advertised for each media format that Chromium supports. This +// mostly includes stuff like reporting proper timestamps, seeking to +// keyframes, and supporting certain features like reordered_opaque. +// +// Known failures as of r53892: +// http://crbug.com/49709 +// sync1_ogg/FFmpegTest.Seek_Audio/0 +// sync1_ogv/FFmpegTest.Seek_Audio/0 +// sync2_ogg/FFmpegTest.Seek_Audio/0 +// sync2_ogv/FFmpegTest.Seek_Audio/0 +// +// http://crbug.com/50457 +// sync0_webm/FFmpegTest.Decode_Video/0 +// sync0_webm/FFmpegTest.Duration/0 +// sync1_webm/FFmpegTest.Decode_Video/0 +// sync2_webm/FFmpegTest.Decode_Video/0 + #include <limits> #include <queue> diff --git a/media/filters/ffmpeg_audio_decoder.cc b/media/filters/ffmpeg_audio_decoder.cc index 133e7dc..827b0bc 100644 --- a/media/filters/ffmpeg_audio_decoder.cc +++ b/media/filters/ffmpeg_audio_decoder.cc @@ -157,7 +157,7 @@ static void ConvertAudioF32ToS32(void* buffer, int buffer_size) { void FFmpegAudioDecoder::DoDecode(Buffer* input) { // FFmpeg tends to seek Ogg audio streams in the middle of nowhere, giving us // a whole bunch of AV_NOPTS_VALUE packets. Discard them until we find - // something valid. + // something valid. Refer to http://crbug.com/49709 // TODO(hclam): remove this once fixing the issue in FFmpeg. if (input->GetTimestamp() == StreamSample::kInvalidTimestamp && estimated_next_timestamp_ == StreamSample::kInvalidTimestamp && |