diff options
author | fbarchard@chromium.org <fbarchard@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-16 00:17:06 +0000 |
---|---|---|
committer | fbarchard@chromium.org <fbarchard@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-16 00:17:06 +0000 |
commit | 876add505792ddb2c7dcb4d33b24f93acd8da2eb (patch) | |
tree | a75a89cb45264454619fc4a389cda4532471aa0c /media | |
parent | bc68ae0afd16651e1ecaf31fd58eff39a74a7d12 (diff) | |
download | chromium_src-876add505792ddb2c7dcb4d33b24f93acd8da2eb.zip chromium_src-876add505792ddb2c7dcb4d33b24f93acd8da2eb.tar.gz chromium_src-876add505792ddb2c7dcb4d33b24f93acd8da2eb.tar.bz2 |
Allow 6 channel to pass thru to driver.
Review URL: http://codereview.chromium.org/155525
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20823 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'media')
-rw-r--r-- | media/audio/win/audio_output_win.cc | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/media/audio/win/audio_output_win.cc b/media/audio/win/audio_output_win.cc index 1ece5eb..bc8c712 100644 --- a/media/audio/win/audio_output_win.cc +++ b/media/audio/win/audio_output_win.cc @@ -88,8 +88,17 @@ namespace { // The next 3 constants are some sensible limits to prevent integer overflow // at this layer. -// TODO(cpu): Some day expand the support and API to more than stereo. -const int kMaxChannels = 2; +// Up to 6 channels can be passed to the driver. +// This should work, given the right drivers, but graceful error handling is +// needed. +// In theory 7.1 could also be supported, but it has not been tested. +// The 192 Khz constant is the frequency of quicktime lossless audio codec. +// MP4 is limited to 96 Khz, and mp3 is limited to 48 Khz. +// OGG vorbis was initially limited to 96 Khz, but recent tools are unlimited. +// 192 Khz is also the limit on most PC audio hardware. The minimum is 100 Hz. +// Humans range is 20 to 20000 Hz. Below 20 can be felt (woofer). + +const int kMaxChannels = 6; const int kMaxSampleRate = 192000; const int kMaxBitsPerSample = 64; |