diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-28 06:56:21 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-28 06:56:21 +0000 |
| commit | c522c4529efde9ec8682bc2213706a3f45d879d9 (patch) | |
| tree | f6c634b9025627ca09051f98b7d435c2226f98d5 /mojo/apps/js/test | |
| parent | 595e54cda57968128e81489e1249126393f114bf (diff) | |
| download | chromium_src-c522c4529efde9ec8682bc2213706a3f45d879d9.zip chromium_src-c522c4529efde9ec8682bc2213706a3f45d879d9.tar.gz chromium_src-c522c4529efde9ec8682bc2213706a3f45d879d9.tar.bz2 | |
Reland: Mojo: add javascript bindings for request/response
If a mojom interface method specifies response parameters, then we'll generate javascript bindings that provide an additional callback parameter used to pass the response parameters. This mirrors the C++ implementation.
A future improvement will likely be to use promises instead, especially now that they are enabled on trunk.
As part of this CL, connector.js was also made consistent with connector.cc. It starts reading the message pipe immediately, handles write failures in a similar fashion, etc.
The Connection type from connector.js is factored out into a separate file as it now holds a Router object. router.js mirrors router.cc. The Connection type is really the mirror of the C++ RemotePtr<S> type.
Some basic request/response tests were added to connection_unittests.js. We'll probably want more testing.
R=abarth@chromium.org
TBR=mpcomplete@chromium.org
Originally reviewed at https://codereview.chromium.org/207503004/
Review URL: https://codereview.chromium.org/216443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260081 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'mojo/apps/js/test')
| -rw-r--r-- | mojo/apps/js/test/run_apps_js_tests.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/mojo/apps/js/test/run_apps_js_tests.cc b/mojo/apps/js/test/run_apps_js_tests.cc index 3427ca4..ade8c26 100644 --- a/mojo/apps/js/test/run_apps_js_tests.cc +++ b/mojo/apps/js/test/run_apps_js_tests.cc @@ -60,12 +60,12 @@ TEST(JSTest, MAYBE_sample_test) { // http://crbug.com/351214 #if defined(OS_POSIX) -#define MAYBE_connector DISABLED_connector +#define MAYBE_connection DISABLED_connection #else -#define MAYBE_connector connector +#define MAYBE_connection connection #endif -TEST(JSTest, MAYBE_connector) { - RunTest("connector_unittests.js", true); +TEST(JSTest, MAYBE_connection) { + RunTest("connection_unittests.js", true); } TEST(JSTest, monotonic_clock) { |